server-tools icon indicating copy to clipboard operation
server-tools copied to clipboard

[11.0][FIX] profiler module fixes

Open thomaspaulb opened this issue 4 years ago • 6 comments

  • Exceptions raised within a profiled request were not dealt with and reraised properly at request end

  • After exception was raised in the request we might not have a db cursor anymore, in that case save stats to file and log where the file is, so that you can still profile

  • Postgresql profiling (for now) only used in 'full' mode

thomaspaulb avatar Feb 07 '21 08:02 thomaspaulb

@sbidoul I changed dns to dnspython, and it seems to install fine, yet is not found by Odoo. What am I doing wrong?

thomaspaulb avatar Aug 13 '22 22:08 thomaspaulb

dns was fine. What's needed is an external_dependencies_override in setup.py. See setuptools-odoo docs for an example. Fortunately this kind of thing has become unnecessary in Odoo 12+ (or 13 not sure).

sbidoul avatar Aug 14 '22 07:08 sbidoul

Are you sure that dns is fine?

(.venv) $ python --version
Python 3.5.10
(.venv) $ pip install dns
ERROR: Could not find a version that satisfies the requirement dns
ERROR: No matching distribution found for dns
(.venv) $ pip install dnspython
Collecting dnspython
  Downloading dnspython-1.16.0-py2.py3-none-any.whl (188 kB)
     |████████████████████████████████| 188 kB 5.4 MB/s 
Installing collected packages: dnspython
Successfully installed dnspython-1.16.0

thomaspaulb avatar Aug 14 '22 08:08 thomaspaulb

Sorry, I mean dns is fine in he manifest external_dependencies. But it must be mapped to dnspython in setup.py.

sbidoul avatar Aug 14 '22 08:08 sbidoul

Thanks!

thomaspaulb avatar Aug 14 '22 09:08 thomaspaulb

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Sep 29 '24 12:09 github-actions[bot]