server-tools icon indicating copy to clipboard operation
server-tools copied to clipboard
verified publisher icon OCA

[13.0] base_jsonify: fix rounding for float fields

Open i-vyshnevska opened this issue 5 years ago • 6 comments

use precision defined on fields for data preparing before data "13.95" returned as "13.950000000000001"

i-vyshnevska avatar Sep 25 '20 12:09 i-vyshnevska

side effect now it returned as a string

i-vyshnevska avatar Sep 25 '20 13:09 i-vyshnevska

@simahawk can you give an opinion on this change

i-vyshnevska avatar Sep 28 '20 10:09 i-vyshnevska

side effect now it returned as a string

this is a problem. It will change the behavior in maaaany places. I'd make this conditional or convert it back to number.

simahawk avatar Sep 28 '20 13:09 simahawk

@simahawk updated

i-vyshnevska avatar Sep 29 '20 08:09 i-vyshnevska

@i-vyshnevska Fix after your rebase: https://github.com/i-vyshnevska/server-tools/pull/1

jcoux avatar Jan 28 '21 11:01 jcoux

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jul 28 '24 12:07 github-actions[bot]