server-brand icon indicating copy to clipboard operation
server-brand copied to clipboard

[19.0][MIG] mail_debranding: migrate

Open tishmen opened this issue 2 months ago • 3 comments

Scope

  • mail_debranding

Depends on

  • None

Summary

  • Import mail_debrand history from OCA/mail 18.0 using git filter-repo (isolated path + rename to mail_debranding) and git am (authors/subjects preserved).
  • Migrate to Odoo 19; set version to 19.0.1.0.0; keep depends=["mail"].
  • Adjust any template/rendering changes for 19.0 if needed.

Temporary references

  • None

Pre-commit

  • Ran locally; auto-fixes committed separately as [IMP].

Tests

  • Local: ./odoo/odoo-bin -c odoo.conf -i mail_debranding --test-enable --log-level=info --stop-after-init
  • Notes: Verify mail notification and signup templates render; ensure “Powered by” link removal still holds.

tishmen avatar Oct 19 '25 13:10 tishmen

Hi @pedrobaeza, mail_debranding migration is ready for review.

  • Imported full history from OCA/mail 18.0, renamed across history mail_debrand → mail_debranding using git filter-repo, then applied with git am to preserve authors/subjects.
  • Migrated to Odoo 19; manifest set to 19.0.1.0.0; no extra deps beyond mail.
  • 19.0 deltas applied in tests: use odoo.tools.urls.urljoin; switch to self.env._; replace deprecated toggle_active with action_unarchive.
  • Commit hygiene: first [IMP] pre-commit auto-fixes, then single [MIG] commit (squashed).

Pre-commit

  • Ran locally; clean.

Tests

  • Local run: ./odoo/odoo-bin -c odoo.conf -i mail_debranding --test-enable --log-level=info --stop-after-init

Please let me know if you want any additional adjustments. Thank you!

tishmen avatar Oct 19 '25 14:10 tishmen

Functional test looks good.

image

However, the phrase "Powered by Odoo" still appears on the login page. I know the module is about mail debranding but maybe it's good to handle them all at once.

image

minhthie avatar Nov 09 '25 13:11 minhthie

@minhthie That functionality is covered in the following pull request: https://github.com/OCA/server-brand/pull/109

tishmen avatar Nov 09 '25 17:11 tishmen