server-brand icon indicating copy to clipboard operation
server-brand copied to clipboard

[16.0][ADD] survey_odoo_debranding

Open kobros-tech opened this issue 6 months ago • 13 comments

kobros-tech avatar Jun 15 '25 14:06 kobros-tech

@pedrobaeza

kobros-tech avatar Jun 15 '25 14:06 kobros-tech

Commit message doesn't follow guidelines: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

It should be [ADD] survey_odoo_debranding: <little module description>.

pedrobaeza avatar Jun 16 '25 06:06 pedrobaeza

The commit message is still incorrect.

pedrobaeza avatar Jun 16 '25 09:06 pedrobaeza

See my previous comment.

pedrobaeza avatar Jun 16 '25 09:06 pedrobaeza

@pedrobaeza it is corrected now

kobros-tech avatar Jun 16 '25 11:06 kobros-tech

You haven't removed [16.0] from the commit message (in the pull request it's OK to have it).

pedrobaeza avatar Jun 16 '25 11:06 pedrobaeza

You haven't removed [16.0] from the commit message (in the pull request it's OK to have it).

[16.0] is removed now

kobros-tech avatar Jun 16 '25 13:06 kobros-tech

Screenshot from 2025-06-17 15-04-09

kobros-tech avatar Jun 17 '25 12:06 kobros-tech

This isn't meant to diminish the effort here, but we sometimes use https://github.com/OCA/server-ux/tree/16.0/template_content_swapper for debranding purposes. I know this approach is somewhat patchy but it does save us hassle from time to time. Just thought I'd share another option. Apologies if this was unnecessary noise.

image

yostashiro avatar Jun 17 '25 13:06 yostashiro

@yostashiro thanks it looks nice for designing purpose, not bad to notify about it.

kobros-tech avatar Jun 17 '25 19:06 kobros-tech

This isn't meant to diminish the effort here, but we sometimes use https://github.com/OCA/server-ux/tree/16.0/template_content_swapper for debranding purposes. I know this approach is somewhat patchy but it does save us hassle from time to time. Just thought I'd share another option. Apologies if this was unnecessary noise.

image

@yostashiro Good pointer, I didn't know that module, it is indeed interesting. However, I still see room for modules like the one proposed here because it is very specific and less technical (you won't need to take care of migrating the "swappers" defined in each database, you just install the new version and surverys are debranded).

LoisRForgeFlow avatar Jun 18 '25 09:06 LoisRForgeFlow

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Oct 19 '25 12:10 github-actions[bot]

@kobros-tech it would be possible to change the name to survey_debranding to unify all the names, as we are doing in 19.0?

pedrobaeza avatar Oct 19 '25 20:10 pedrobaeza