[18.0] [MIG] base_external_dbsource_mssql

[Nikul-OSI]

[max3903]

/ocabot migration base_external_dbsource_mssql

[dreispt]

@Nikul-OSI tests are failing

[Nikul-OSI]

@Nikul-OSI tests are failing

@dreispt It's not related to our code; it failed because the library didn't load properly.

ImportError: libodbc.so.2: cannot open shared object file: No such file or directory

[Nikul-OSI]

@max3903 @dreispt Tests and pre-commit now :green_heart:

[pedrobaeza]

Please solve conflicts.

[Nikul-OSI]

Please solve conflicts.

Done @pedrobaeza

[christian-ramos-tecnativa]

I'm not entirely convinced about the approach taken for the MSSQL ODBC implementation. As it stands, the open, close, and execute methods are identical for both types, and the shared logic is relying on the connector field for filtering.

In my opinion, it would be cleaner to introduce a new field, mssql_type (defaulting to alchemy), in base.external.dbsource, and then use that field for filtering in the _execute_mssql method. This way, the rest of the logic can remain unchanged. @Nikul-OSI @max3903 WDYT

[pedrobaeza]

Superseded by #392