server-backend icon indicating copy to clipboard operation
server-backend copied to clipboard

[19.0][MIG] base_user_role: Migration to 19.0

Open tishmen opened this issue 2 months ago • 6 comments

Scope

  • base_user_role only

Summary

  • Migrate to Odoo 19.0 following OCA guide.
  • API updates: group_ids rename, SUPERUSER_ID import from odoo.api.
  • Switch to models.Constraint and models.Index APIs.
  • Switch to res.groups privilege_id (drop category_id).
  • Replace trans_implied_ids usages with all_implied_ids where effective groups are expected.
  • Adjust search/tree view xpaths and <search><group> schema for 19.0.
  • Refactor default roles due to removal of default user in Odoo.

Pre-commit

  • Verified locally; auto-fixes applied and committed.

Tests

Command:

./odoo/odoo-bin -c odoo.conf -d bur19_tests_bur -i base_user_role --test-enable --test-tags "/base_user_role" --without-demo=all --log-level=info --stop-after-init

Result: green locally.

tishmen avatar Oct 09 '25 13:10 tishmen

Base migration PR for the role stack. Two downstream PRs depend on this PR via a temporary test requirement, following OCA guidance:

https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference(s)-to-another-pull-request(s)

Dependent PRs

  • #383 base_user_role_company
  • #384 base_user_role_history

Notes

  • The dependents include a commit titled "[DON'T MERGE] test-requirements.txt"; we will drop that commit once this base PR is merged.
  • Local tests are green. Command used:
./odoo/odoo-bin -c odoo.conf -d bur19_tests_bur -i base_user_role --test-enable --test-tags "/base_user_role" --without-demo=all --log-level=info --stop-after-init

Maintainers ping

  • @sebalix @jcdrubay @novawish — thanks in advance for an initial look. This PR is kept as draft; happy to mark ready once you prefer.

tishmen avatar Oct 09 '25 13:10 tishmen

/ocabot migration base_user_role

rousseldenis avatar Oct 11 '25 11:10 rousseldenis

@tishmen Is this ready ? Some of commits can be squashed in migration one. If there are improvements, they can stay but making module name appear in commit message. Thanks

rousseldenis avatar Oct 11 '25 11:10 rousseldenis

@rousseldenis From my side this is ready for another look; The module is installing and checks/tests are passing. I’ll squash the migration-only changes into a single “[19.0] [MIG] …” commit and ping you once done.

tishmen avatar Oct 11 '25 14:10 tishmen

@FrancoMaxime @rousseldenis The commits have been squashed as suggested, please check the last commit for the full diff. Thank you!

tishmen avatar Oct 15 '25 18:10 tishmen

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Nov 10 '25 10:11 OCA-git-bot

/ocabot merge nobump

StefanRijnhart avatar Nov 27 '25 10:11 StefanRijnhart

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 19.0-ocabot-merge-pr-382-by-StefanRijnhart-bump-nobump, awaiting test results.

OCA-git-bot avatar Nov 27 '25 10:11 OCA-git-bot

Congratulations, your PR was merged at 9b05edd17fd1bf67a3ef0903c19c64b6d8adcf6b. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Nov 27 '25 10:11 OCA-git-bot