server-backend icon indicating copy to clipboard operation
server-backend copied to clipboard

[15.0][MIG] base_user_role_company

Open hbrunn opened this issue 2 years ago • 7 comments

this is a backport from v16 as it contains patches the previous v15 PRs (https://github.com/OCA/server-backend/pull/139, https://github.com/OCA/server-backend/pull/187) didn't

hbrunn avatar Sep 27 '23 09:09 hbrunn

/ocabot migration base_user_role_company

hbrunn avatar Sep 27 '23 17:09 hbrunn

There's no issue in this repo with the title 'Migration to version 15.0' and the milestone 15.0, so not possible to add the comment.

OCA-git-bot avatar Sep 27 '23 17:09 OCA-git-bot

@hbrunn Looks good. Perhaps a small glitch (not associated with the migration) is that when you access to the users associated to a role, from the role, the company assigned to the user is not visible.

image

It is only visible from the user:

image

JordiBForgeFlow avatar Jan 25 '24 16:01 JordiBForgeFlow

@JordiBForgeFlow I think I can slip this into this PR if nobody objects?

Do you have an opinion about https://github.com/OCA/server-backend/pull/241#pullrequestreview-1646067495 ?

hbrunn avatar Jan 25 '24 17:01 hbrunn

@hbrunn I would add the change as a separate commit, so that we can fwp and backport.

JordiBForgeFlow avatar Jan 25 '24 17:01 JordiBForgeFlow

added the company column on the user tab in roles in https://github.com/OCA/server-backend/pull/241/commits/a2e03bf0f7f33c2741d87335d93009c155bbab4b, and fixed the behavior for multiple selected companies in https://github.com/OCA/server-backend/pull/241/commits/28c9cec393e1b8f430c28d096a0a393abffc1079

hbrunn avatar Feb 19 '24 15:02 hbrunn

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jun 30 '24 12:06 github-actions[bot]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Dec 22 '24 12:12 github-actions[bot]