[16.0] base_external_dbsource_mssql requirements break odoo core compatibily

[flotho]

Module

base_external_dbsource_mssql

sqlalchemy in requirements file

Describe the bug

the requirement cause incompatibilty issues with greenlet

/home/odoo_16/.local/lib/python3.9/site-packages (from -r /home/odoo_16/additionnal_repositories/OCA-server-backend/requirements.txt (line 3)) (2.0.15)\nRequirement already satisfied: typing-extensions>=4.2.0 in /home/odoo_16/.local/lib/python3.9/site-packages (from sqlalchemy->-r /home/odoo_16/additionnal_repositories/OCA-server-backend/requirements.txt (line 3)) (4.5.0)\nCollecting greenlet!=0.4.17 (from sqlalchemy->-r /home/odoo_16/additionnal_repositories/OCA-server-backend/requirements.txt (line 3))\n  **Downloading greenlet-2.0.2-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl** (610 kB)\n

when greenlet 2.0.2 is installed we have issues like this : https://github.com/gevent/gevent/issues/1685

if I desinstall sqlalchemy and force the installation of the odoo requirements everything works fine

To Reproduce

install requirement on a v16 with python 3.9

Expected behavior

no issue while running Odoo

Additional context

rocky linux 9

[flotho]

ping @anddago78

[flotho]

hum... looks like it happens for python <= 3.9

[BT-aleonard]

Hi @flotho , Any news for this bug?

[flotho]

yes, I confirm that the requirements has to be adapted regarding the python version

[flotho]

this combination of releases works great on v16 :

• sqlalchemy==1.3.24
• greenlet==0.4.17 ; python_version > '3.7' and python_version <= '3.9'
• greenlet==1.1.2 ; python_version > '3.9' and python_version <= '3.10' # (Jammy)

[BT-aleonard]

Thank you very much, did you make a PR to fix this?

[flotho]

not at all because I'm not sure how to declare such pattern in manifest files. And if I'm correct requirements are generated by the manifest. If you lead me on this I can do the PR with pleasure.

[BT-aleonard]

You can create a PR to create a requirements file in the repo.

[flotho]

You can create a PR to create a requirements file in the repo.

Hi @BT-aleonard , I disagree with your proposal. Requirements.txt are generated by the dependencies put in the manifest files. And I' m not sure of the pattern . But anyway I can make a PR to modify manifests ;-)

[flotho]

hi @BT-aleonard , finally it was easy, feel free to review the PR Regards

[github-actions[bot]]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.