server-auth icon indicating copy to clipboard operation
server-auth copied to clipboard

[MIG] auth_jwt_demo: Migration to 18.0

Open kobros-tech opened this issue 9 months ago • 1 comments

  • [ ] https://github.com/OCA/server-auth/pull/752

kobros-tech avatar Apr 01 '25 05:04 kobros-tech

@sbidoul

demo is there now, I had to ignore eslint for js test files, also warn message had to be ignored for CI test.

kobros-tech avatar Apr 01 '25 07:04 kobros-tech

Also, let's not change auth_jwt_demo/tests/spa/js/oidc-client.js. This file is an external lib. We should exclude it from the linter.

sbidoul avatar May 15 '25 16:05 sbidoul

/ocabot migration auth_jwt_demo

sbidoul avatar May 15 '25 16:05 sbidoul

Also, let's not change auth_jwt_demo/tests/spa/js/oidc-client.js. This file is an external lib. We should exclude it from the linter.

how can I exclude a file?

@sbidoul

kobros-tech avatar Jun 17 '25 01:06 kobros-tech

Also, let's not change auth_jwt_demo/tests/spa/js/oidc-client.js. This file is an external lib. We should exclude it from the linter.

how can I exclude a file?

@sbidoul

Probably somewhere in this file https://github.com/OCA/server-auth/blob/0771ec76cd9f593acb3f1260fe4ed374c4c00522/.pre-commit-config.yaml#L115

TDu avatar Jun 24 '25 10:06 TDu

@kobros-tech is this ready for review?

dnplkndll avatar Aug 24 '25 03:08 dnplkndll

@kobros-tech is this ready for review?

to me yes, but I am waiting for @sbidoul to tell his opinion.

kobros-tech avatar Aug 24 '25 10:08 kobros-tech

@kobros-tech I'm finishing this in #846. The log capture you made here is too broad as we expect the warning in exactly one test.

sbidoul avatar Oct 09 '25 13:10 sbidoul

Thanks for you help with this migration nevertheless!

sbidoul avatar Oct 09 '25 13:10 sbidoul