server-auth icon indicating copy to clipboard operation
server-auth copied to clipboard

Migration to version 18.0

Open OCA-git-bot opened this issue 1 year ago • 23 comments

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

Modules to migrate

  • [x] auth_admin_passkey - By @BT-dlagin - #740
  • [ ] auth_admin_passkey_totp_mail_enforce
  • [x] auth_api_key - By @thienvh332 - #701
  • [x] auth_api_key_group - By @thienvh332 - #703
  • [x] auth_api_key_server_env - By @thienvh332 - #702
  • [x] auth_jwt - By @dnplkndll - #752
  • [ ] auth_jwt_demo - By @kobros-tech - #780
  • [ ] auth_oauth_autologin
  • [x] auth_oauth_filter_by_domain - By @natuan9 - #781
  • [x] auth_oauth_multi_token - By @dnplkndll - #754
  • [x] auth_oidc - By @ap-wtioit - #705
  • [x] auth_saml - By @BT-dlagin - #745
  • [x] auth_signup_verify_email - By @JrAdhoc - #727
  • [x] auth_user_case_insensitive - By @JessBrandl - #785
  • [x] base_user_empty_password - By @chaule97 - #699
  • [x] base_user_show_email - By @lef-adhoc - #718
  • [ ] impersonate_login
  • [x] password_security - By @IsabelAForgeFlow - #773
  • [x] user_log_view - By @jqbeltran2 - #850
  • [x] users_ldap_mail - By @eduezerouali-tecnativa - #838

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

OCA-git-bot avatar Oct 06 '24 16:10 OCA-git-bot

working on (ready for review) auth_oidc #705

ap-wtioit avatar Oct 09 '24 12:10 ap-wtioit

Working on user_log_view and auth_admin_passkey

moncefarajdal avatar Oct 15 '24 13:10 moncefarajdal

user_log_view : #711

moncefarajdal avatar Oct 15 '24 14:10 moncefarajdal

auth_user_case_insensitive : #712

moncefarajdal avatar Oct 16 '24 07:10 moncefarajdal

I have a question: Should I add my name in the contributors in the README file before the pull request is merged?

moncefarajdal avatar Oct 16 '24 11:10 moncefarajdal

If the migration means some significant time (not only changing the version number), then yes, it's acceptable that you become a contributor there.

pedrobaeza avatar Oct 16 '24 11:10 pedrobaeza

@pedrobaeza In this module auth_user_case_insensitive there was a significant change in the super()._login method so I adapted it to the new version and also updated the test cases. Does this count as a significant contribution?

moncefarajdal avatar Oct 16 '24 11:10 moncefarajdal

Go ahead then. Take into account that this is a bit subjective, and what "we" (understood as the community) don't want is that people abuses the system to place it as a top contributor. But right now, your contributions seem valuable and checked carefully.

pedrobaeza avatar Oct 16 '24 11:10 pedrobaeza

auth_signup_verify_email: #727

JrAdhoc avatar Nov 14 '24 15:11 JrAdhoc

@moncefarajdal Hi, I would like to migrate auth_admin_passkey. Are you working on it or not? Can I take over? Found out closed PR from you - https://github.com/OCA/server-auth/pull/710 Thanks!

BT-dlagin avatar Dec 20 '24 10:12 BT-dlagin

@BT-dlagin Hey, Yeah please go ahead. Thanks!

moncefarajdal avatar Dec 20 '24 10:12 moncefarajdal

Working on auth_admin_passkey

BT-dlagin avatar Dec 20 '24 10:12 BT-dlagin

Working on auth_saml

BT-dlagin avatar Jan 08 '25 09:01 BT-dlagin

It seems like auth_ldaps is missing in the list, which is available in 17.0 already: https://github.com/OCA/server-auth/tree/17.0/auth_ldaps

mschulz-asphericon avatar Jan 17 '25 14:01 mschulz-asphericon

Done (ready for review)auth_user_case_insensitive: #756

El-khamisi avatar Jan 23 '25 00:01 El-khamisi

  • Migrated auth_session_timeout in https://github.com/OCA/server-auth/pull/766

mcodes-o avatar Feb 21 '25 22:02 mcodes-o

Migrated auth_ldap_attribute_sync in #830 from 12.0

ap-wtioit avatar Aug 13 '25 09:08 ap-wtioit

Working on auth_ldaps

BT-pkosnik avatar Aug 21 '25 11:08 BT-pkosnik

user_log_view: #787

jqbeltran2 avatar Sep 02 '25 19:09 jqbeltran2

Migrated users_ldap_populate in #841 from 17.0

ap-wtioit avatar Sep 23 '25 12:09 ap-wtioit

Hi,

users_ldap_groups is missing in the "modules to migrate" list. Has this functionality been integrated elsewhere, or is it just a mistake in the list?

Regards.

atrueba avatar Nov 17 '25 21:11 atrueba

@atrueba user_ldap_groups was migrated to 17.0 after this list was created, if you want to migrate it, you're welcome to open the PR and mention it here.

ap-wtioit avatar Nov 18 '25 06:11 ap-wtioit

@ap-wtioit

@atrueba user_ldap_groups was migrated to 17.0 after this list was created, if you want to migrate it, you're welcome to open the PR and mention it here.

I'd like to, but I'm (yet) more of a power-user than a developer. For the time being, I'm OK just having this comment here in case there's other people interested.

atrueba avatar Nov 18 '25 08:11 atrueba