server-auth
server-auth copied to clipboard
Migration to version 18.0
Todo
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0
Modules to migrate
- [x] auth_admin_passkey - By @BT-dlagin - #740
- [ ] auth_admin_passkey_totp_mail_enforce
- [x] auth_api_key - By @thienvh332 - #701
- [x] auth_api_key_group - By @thienvh332 - #703
- [x] auth_api_key_server_env - By @thienvh332 - #702
- [x] auth_jwt - By @dnplkndll - #752
- [ ] auth_jwt_demo - By @kobros-tech - #780
- [ ] auth_oauth_autologin
- [x] auth_oauth_filter_by_domain - By @natuan9 - #781
- [x] auth_oauth_multi_token - By @dnplkndll - #754
- [x] auth_oidc - By @ap-wtioit - #705
- [x] auth_saml - By @BT-dlagin - #745
- [x] auth_signup_verify_email - By @JrAdhoc - #727
- [x] auth_user_case_insensitive - By @JessBrandl - #785
- [x] base_user_empty_password - By @chaule97 - #699
- [x] base_user_show_email - By @lef-adhoc - #718
- [ ] impersonate_login
- [x] password_security - By @IsabelAForgeFlow - #773
- [x] user_log_view - By @jqbeltran2 - #850
- [x] users_ldap_mail - By @eduezerouali-tecnativa - #838
Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list
working on (ready for review) auth_oidc #705
Working on user_log_view and auth_admin_passkey
user_log_view : #711
auth_user_case_insensitive : #712
I have a question: Should I add my name in the contributors in the README file before the pull request is merged?
If the migration means some significant time (not only changing the version number), then yes, it's acceptable that you become a contributor there.
@pedrobaeza In this module auth_user_case_insensitive there was a significant change in the super()._login method so I adapted it to the new version and also updated the test cases. Does this count as a significant contribution?
Go ahead then. Take into account that this is a bit subjective, and what "we" (understood as the community) don't want is that people abuses the system to place it as a top contributor. But right now, your contributions seem valuable and checked carefully.
auth_signup_verify_email: #727
@moncefarajdal Hi, I would like to migrate auth_admin_passkey. Are you working on it or not? Can I take over? Found out closed PR from you - https://github.com/OCA/server-auth/pull/710 Thanks!
@BT-dlagin Hey, Yeah please go ahead. Thanks!
Working on auth_admin_passkey
Working on auth_saml
It seems like auth_ldaps is missing in the list, which is available in 17.0 already:
https://github.com/OCA/server-auth/tree/17.0/auth_ldaps
Done (ready for review)auth_user_case_insensitive: #756
- Migrated
auth_session_timeoutin https://github.com/OCA/server-auth/pull/766
Migrated auth_ldap_attribute_sync in #830 from 12.0
Working on auth_ldaps
user_log_view: #787
Migrated users_ldap_populate in #841 from 17.0
Hi,
users_ldap_groups is missing in the "modules to migrate" list. Has this functionality been integrated elsewhere, or is it just a mistake in the list?
Regards.
@atrueba user_ldap_groups was migrated to 17.0 after this list was created, if you want to migrate it, you're welcome to open the PR and mention it here.
@ap-wtioit
@atrueba user_ldap_groups was migrated to 17.0 after this list was created, if you want to migrate it, you're welcome to open the PR and mention it here.
I'd like to, but I'm (yet) more of a power-user than a developer. For the time being, I'm OK just having this comment here in case there's other people interested.