server-auth icon indicating copy to clipboard operation
server-auth copied to clipboard

[MIG] auth_oauth_autologin: Migration to 17.0

Open Loregs2 opened this issue 1 year ago • 5 comments

Standard migration to 17.0

Loregs2 avatar Jun 04 '24 14:06 Loregs2

LGTM

jaenbox avatar Jun 14 '24 09:06 jaenbox

@Loregs2 /web/login?no_autologin not working at the moment similar to #627

CasVissers-360ERP avatar Aug 23 '24 10:08 CasVissers-360ERP

@CasVissers-360ERP @Loregs2 I pushed a fix for the ?no_autologin

benwillig avatar Aug 28 '24 12:08 benwillig

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Dec 29 '24 12:12 github-actions[bot]

This module works for me. What needs to be done to have it merged?

anikeenko-viktor avatar Jan 13 '25 10:01 anikeenko-viktor

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar May 25 '25 12:05 github-actions[bot]

This module works for me. What needs to be done to have it merged?

You can check ‘Approve’ in the Review changes section of the files, thanks.

Loregs2 avatar Jun 02 '25 15:06 Loregs2

@Loregs2 fix with ?no_autologin is not included unless it's not needed anymore? https://github.com/OCA/server-auth/pull/627/files#diff-f3238b0909b811978b1f783e9dde0a41031587b3de012f0356a68c81c855e043R15

Otherwise it looks ok

benwillig avatar Jun 02 '25 15:06 benwillig

@Loregs2 fix with ?no_autologin is not included unless it's not needed anymore? https://github.com/OCA/server-auth/pull/627/files#diff-f3238b0909b811978b1f783e9dde0a41031587b3de012f0356a68c81c855e043R15

Otherwise it looks ok

You were right, I have added that change and the ?no_autologin is now working. Thank you.

Loregs2 avatar Jun 03 '25 10:06 Loregs2

/ocabot migration auth_oauth_autologin /ocabot merge nobump

dreispt avatar Jun 14 '25 14:06 dreispt

What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-658-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot avatar Jun 14 '25 14:06 OCA-git-bot

Congratulations, your PR was merged at 27778a47ba4bbf5d9f34ee8b62e3269f45a1e95f. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jun 14 '25 14:06 OCA-git-bot