server-auth icon indicating copy to clipboard operation
server-auth copied to clipboard

[MIG] auth_oauth_autologin: Migration to 16.0

Open benwillig opened this issue 1 year ago • 6 comments

benwillig avatar Mar 20 '24 14:03 benwillig

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jul 21 '24 12:07 github-actions[bot]

/ocabot migration auth_oauth_autologin

sbidoul avatar Aug 11 '24 12:08 sbidoul

@benwillig In the past I think we could pass a ?no_autologin to the /web/login route to prevent autologin.

This does not seem to work anymore. Maybe it's just me?

sbidoul avatar Aug 11 '24 12:08 sbidoul

@sbidoul Yes no_autologin should avoid the redirection but it doesn't look to be working properly. I will take a look at it.

benwillig avatar Aug 19 '24 07:08 benwillig

@sbidoul keep_blank_values=True was missing when parsing the query. It should work as expected now.

benwillig avatar Aug 28 '24 12:08 benwillig

Tested: https://oca-server-auth-16-0-pr627-5df0507fe3c9.runboat.odoo-community.org/web/login?no_autologin https://oca-server-auth-16-0-pr627-5df0507fe3c9.runboat.odoo-community.org/web/login

CasVissers-360ERP avatar Aug 28 '24 18:08 CasVissers-360ERP

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Dec 29 '24 12:12 github-actions[bot]

/ocabot merge nobump

sbidoul avatar Jan 22 '25 13:01 sbidoul

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-627-by-sbidoul-bump-nobump, awaiting test results.

OCA-git-bot avatar Jan 22 '25 13:01 OCA-git-bot

Thanks @vincent-hatakeyama !

sbidoul avatar Jan 22 '25 13:01 sbidoul

Congratulations, your PR was merged at c84e2d2f0d86be1024ca620ded06ca1088840f2b. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jan 22 '25 13:01 OCA-git-bot