server-auth icon indicating copy to clipboard operation
server-auth copied to clipboard

[FIX][14.0] auth_saml: readme an link to the runboat

Open leemannd opened this issue 1 year ago • 13 comments

These changes where introduced with the backport of the refactoring of the module auth_saml in -> https://github.com/OCA/server-auth/commit/cd6082aef3150d089317795a53a057d4452aeaf7

In this PR I change them back to values related to 14.0 for more consistency

leemannd avatar Mar 12 '24 12:03 leemannd

Hello @vincent-hatakeyama Can you have a look at this README and runboat link update?

leemannd avatar Mar 20 '24 10:03 leemannd

Those files are automatically updated by the runbot.

For the information about the changes, you need to edit readme/HISTORY.rst that is used by the runbot.

vincent-hatakeyama avatar Apr 29 '24 16:04 vincent-hatakeyama

@OCA/tools-maintainers The author of this PR tries to fix the index.html file directly but that file is supposed to be generated automatically. The README of the 14.0 branch is correct but auth_saml/ references the 15.0 branch. Is there a way to force the bot to do the update?

vincent-hatakeyama avatar Apr 30 '24 07:04 vincent-hatakeyama

@vincent-hatakeyama Something went wrong there. Recent version of pre-commit ensure the README is generated.

dreispt avatar Apr 30 '24 07:04 dreispt

/ocabot merge patch

dreispt avatar Apr 30 '24 07:04 dreispt

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-623-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot avatar Apr 30 '24 07:04 OCA-git-bot

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-623-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Apr 30 '24 08:04 OCA-git-bot

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-623-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Apr 30 '24 08:04 OCA-git-bot

@dreispt @pedrobaeza Should we maybe do a manual merge in this situation? It's just readme updates so there's no harm done

thomaspaulb avatar Apr 30 '24 08:04 thomaspaulb

seems to me you fell victim of https://github.com/OCA/oca-addons-repo-template/issues/250#issuecomment-2084674256 - retry?

/ocabot merge patch

hbrunn avatar Apr 30 '24 08:04 hbrunn

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-623-by-hbrunn-bump-patch, awaiting test results.

OCA-git-bot avatar Apr 30 '24 08:04 OCA-git-bot

@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-623-by-hbrunn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Apr 30 '24 08:04 OCA-git-bot

You have to wait until the situation with Codecov is resolved.

pedrobaeza avatar Apr 30 '24 08:04 pedrobaeza

Closing as old and outdated

leemannd avatar Jun 19 '24 12:06 leemannd