sale-workflow icon indicating copy to clipboard operation
sale-workflow copied to clipboard

[17.0][MIG] sale_order_product_assortment: Migration to 17.0

Open DantePereyra opened this issue 8 months ago • 4 comments

Standard migration

Depends on:

  • [ product_assortment] https://github.com/OCA/product-attribute/pull/1913

DantePereyra avatar Apr 08 '25 10:04 DantePereyra

/ocabot migration sale_order_product_assortment

rousseldenis avatar Apr 23 '25 16:04 rousseldenis

@rousseldenis could you review it again? product_assortment was merged, it's perfect timing!

DantePereyra avatar May 07 '25 06:05 DantePereyra

Hi @DantePereyra Can you add this commit db8fb324c9ab08e04fd257702b9b50657dedc821

sergio-teruel avatar May 08 '25 12:05 sergio-teruel

Hi @sergio-teruel, I saw that, and also your commit d42eb91a79c0b14afba118cd3201a9285688edec, which adds security groups and compute_sudo=True on allowed_product_ids. Should I include that commit as well? Bringing only one seems incomplete to me, but I’ll leave that decision up to you. Thanks!

DantePereyra avatar May 08 '25 14:05 DantePereyra

@sergio-teruel Could you answer ? Thanks

rousseldenis avatar May 23 '25 09:05 rousseldenis

Hi @rousseldenis @sergio-teruel,I’ve finally brought in those commits and made a few adjustments. Could you please review it again and let me know if everything looks good? Thanks!

DantePereyra avatar Jun 03 '25 14:06 DantePereyra

@OCA/sale-workflow-maintainers, could you take a look on this? Thanks!

DantePereyra avatar Jun 27 '25 11:06 DantePereyra

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jun 27 '25 13:06 OCA-git-bot

/ocabot merge nobump

pedrobaeza avatar Jun 27 '25 13:06 pedrobaeza

On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-3669-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot avatar Jun 27 '25 13:06 OCA-git-bot

Congratulations, your PR was merged at 5775be8d93190feaf5f11194eddbef72ad42d7c3. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jun 27 '25 13:06 OCA-git-bot