sale-workflow icon indicating copy to clipboard operation
sale-workflow copied to clipboard

[MIG] sale_discount_display_amount: Migration to 17.0

Open FSchiepers opened this issue 2 years ago • 5 comments

This version adds the possibility to choose whether the discount is calculated based on the non-taxed subtotal or the taxed total, see: https://github.com/OCA/sale-workflow/issues/2813

Correction from https://github.com/OCA/sale-workflow/pull/2987

FSchiepers avatar Mar 18 '24 10:03 FSchiepers

/ocabot migration sale_discount_display_amount

FSchiepers avatar Mar 18 '24 11:03 FSchiepers

Sorry @FSchiepers you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

OCA-git-bot avatar Mar 18 '24 11:03 OCA-git-bot

/ocabot migration sale_discount_display_amount

rousseldenis avatar Mar 18 '24 16:03 rousseldenis

@FSchiepers Could you improve your commit messages :

image

Something like [IMP] sale_discount_display_amount: (...)

Thanks

rousseldenis avatar Apr 15 '24 11:04 rousseldenis

I added comments, can you review please?

FSchiepers avatar Apr 30 '24 08:04 FSchiepers

rebased to https://github.com/OCA/sale-workflow/pull/3160

FSchiepers avatar May 29 '24 11:05 FSchiepers