sale-workflow icon indicating copy to clipboard operation
sale-workflow copied to clipboard

[17.0][MIG] sale_partner_incoterm: Migration to 17.0

Open StefanRijnhart opened this issue 2 years ago • 5 comments

StefanRijnhart avatar Feb 21 '24 19:02 StefanRijnhart

/ocabot migration sale_partner_incoterm

StefanRijnhart avatar Feb 21 '24 19:02 StefanRijnhart

/ocabot migration sale_partner_incoterm

rousseldenis avatar Mar 12 '24 16:03 rousseldenis

@traitrantrobz I followed https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#technical-method-to-migrate-a-module-from-160-to-170-branch which has the following line:

git commit -m "[MIG] $module: Migration to 17.0"

This results in my commit message

image

I believe this to be correct. Can you agree with it?

StefanRijnhart avatar Jul 22 '24 10:07 StefanRijnhart

@traitrantrobz I followed https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#technical-method-to-migrate-a-module-from-160-to-170-branch which has the following line:

git commit -m "[MIG] $module: Migration to 17.0"

This results in my commit message

image

I believe this to be correct. Can you agree with it?

I mean you should change the title PR. [17.0][MIG] sale_partner_incoterm: Migration to 17.0

traitrantrobz avatar Jul 23 '24 10:07 traitrantrobz

I mean you should change the title PR. [17.0][MIG] sale_partner_incoterm: Migration to 17.0

@traitrantrobz Thanks, underscores restored!

StefanRijnhart avatar Jul 23 '24 18:07 StefanRijnhart

@traitrantrobz Your 'Request Changes' review is blocking the approved status of this PR. Can you update your review please?

StefanRijnhart avatar Aug 19 '24 19:08 StefanRijnhart

/ocabot merge nobump

rousseldenis avatar Aug 23 '24 08:08 rousseldenis

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-2968-by-rousseldenis-bump-nobump, awaiting test results.

OCA-git-bot avatar Aug 23 '24 08:08 OCA-git-bot

Congratulations, your PR was merged at 27eb72934cadcda561daeb3019880c81a420ebb2. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Aug 23 '24 08:08 OCA-git-bot