sale-workflow icon indicating copy to clipboard operation
sale-workflow copied to clipboard

[16.0][ADD] - sale_order_line_cancel

Open sbejaoui opened this issue 3 years ago • 9 comments

This module allows you to cancel the remaining quantity on sale order by adding a dedicated action to sale lines. It also add two new fields to track canceled and remaining to deliver quantities.

sbejaoui avatar Feb 02 '23 14:02 sbejaoui

cc/ @lmignon

sbejaoui avatar Feb 02 '23 14:02 sbejaoui

@sbejaoui I tested the odoo native behavior and it seems that this addon ..

Thanks @lmignon for your input,

I understand your PoV, It's true that the change of the ordered quantity trigger the change/cancellation of the related moves.

This feature is meant to simplify the process and make it done with a simple click. It also keep the information of the initial ordered quantity and store the canceled quantity. The difference between the two fields may be helpful for sale reporting.

The dependency to https://github.com/OCA/stock-logistics-workflow/pull/1202 is not a must. It's, IMO, a simpler way to get all sale line related moves instead of recursive loop.

sbejaoui avatar Feb 06 '23 15:02 sbejaoui

@sbejaoui I tested the odoo native behavior and it seems that this addon ..

Thanks @lmignon for your input,

I understand your PoV, It's true that the change of the ordered quantity trigger the change/cancellation of the related moves.

This feature is meant to simplify the process and make it done with a simple click. It also keep the information of the initial ordered quantity and store the canceled quantity. The difference between the two fields may be helpful for sale reporting.

The dependency to OCA/stock-logistics-workflow#1202 is not a must. It's, IMO, a simpler way to get all sale line related moves instead of recursive loop.

IMO, the functionality should only be available if the change of qty on confirmed sale order is activated..

lmignon avatar Feb 07 '23 09:02 lmignon

The dependency to OCA/stock-logistics-workflow#1202 is not a must. It's, IMO, a simpler way to get all sale line related moves instead of recursive loop.

Just a side note that this way of finding the right moves of the chain is not safe as moves can be merged. For example, a single pick move could serve multiple delivery moves. This specific use case is covered by the stock_available_to_promise_release module which, in case you cancel the outgoing move, will unrelease the outgoing move and while unreleasing it, will go through the picking chain up to the source picking and split any merged move.

A solution would be that this module only cancel the outgoing move and have another module using the dependency to OCA/stock-logistics-workflow#1202 to propagate the cancelation.

You can maybe add this remark in a ROADMAP file.

jbaudoux avatar Mar 30 '23 18:03 jbaudoux

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Apr 03 '23 07:04 OCA-git-bot

ping @sbejaoui :)

cyrilmanuel avatar Nov 23 '23 07:11 cyrilmanuel

thank you @sbejaoui :+1: @rousseldenis can yo check the PR ?

cyrilmanuel avatar Nov 24 '23 07:11 cyrilmanuel

Hi @sbejaoui little ping, could you check about the comment of @jbaudoux ?

cyrilmanuel avatar Mar 26 '24 10:03 cyrilmanuel

See https://github.com/acsone/sale-workflow/pull/4

jbaudoux avatar May 08 '24 15:05 jbaudoux

@rousseldenis Is this now also good for you? Can you update your review?

jbaudoux avatar Jan 19 '25 17:01 jbaudoux

/ocabot merge nobump

rousseldenis avatar Jan 31 '25 15:01 rousseldenis

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-2357-by-rousseldenis-bump-nobump, awaiting test results.

OCA-git-bot avatar Jan 31 '25 15:01 OCA-git-bot

Congratulations, your PR was merged at c6a38598ab59960838045f1a384171e98c979c0c. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jan 31 '25 15:01 OCA-git-bot