rest-framework icon indicating copy to clipboard operation
rest-framework copied to clipboard

[16.0][IMP]fastapi: enable multi-slash routes

Open PicchiSeba opened this issue 8 months ago • 8 comments

This is a Work In Progress PR, which attempts to address this issue https://github.com/OCA/rest-framework/issues/446. Any suggestion is welcome

EDIT: depends on https://github.com/OCA/rest-framework/pull/524

PicchiSeba avatar Apr 01 '25 08:04 PicchiSeba

Hi @lmignon, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Apr 01 '25 08:04 OCA-git-bot

The error seems unrelated to this PR

AttributeError: module 'marshmallow' has no attribute 'pprint'

PicchiSeba avatar Apr 30 '25 10:04 PicchiSeba

once https://github.com/OCA/rest-framework/pull/527 is merged, a rebase will solve the CI

lmignon avatar May 14 '25 13:05 lmignon

Thank you for this great improvement @PicchiSeba

LGTM (Code review, functionnal tests)

Thank you for your support and technical expertize!

PicchiSeba avatar May 15 '25 07:05 PicchiSeba

ping @AnizR @sbidoul

lmignon avatar Jun 04 '25 10:06 lmignon

I accidentally squashed the new test into the merge commit, it should be good now

PicchiSeba avatar Jun 11 '25 07:06 PicchiSeba

@lmignon I removed the useless test class

PicchiSeba avatar Jun 11 '25 07:06 PicchiSeba

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jun 23 '25 15:06 OCA-git-bot

/ocabot merge minor

lmignon avatar Jun 25 '25 08:06 lmignon

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-515-by-lmignon-bump-minor, awaiting test results.

OCA-git-bot avatar Jun 25 '25 08:06 OCA-git-bot

Congratulations, your PR was merged at 6f480bf1de5160e4d5881388d1672f9d664a7fa1. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jun 25 '25 08:06 OCA-git-bot