OCA
[17.0][FIX] fastapi_auth_jwt: add some missing code
@lmignon The module is merged without updating its version in the manifest file, it was uninstallable.
The dependent modules were not installed due to this issue.
@lmignon The module is merged without updating its version in the manifest file, it was uninstallable.
The dependent modules were not installed due to this issue.
it's because it's not migrated and the branch 17.0 has been created from the 16.0 one. (not from an empty branch). If you need to use this addon, you need to migrate it.
@lmignon The module is merged without updating its version in the manifest file, it was uninstallable. The dependent modules were not installed due to this issue.
it's because it's not migrated and the branch 17.0 has been created from the 16.0 one. (not from an empty branch). If you need to use this addon, you need to migrate it.
no problem, can we merge it so that this issues will vanish...
@lmignon The module is merged without updating its version in the manifest file, it was uninstallable. The dependent modules were not installed due to this issue.
it's because it's not migrated and the branch 17.0 has been created from the 16.0 one. (not from an empty branch). If you need to use this addon, you need to migrate it.
no problem, can we merge it so that this issues will vanish...
Tests and runboat are :red_circle: Therefore it can't be merged.
@lmignon The module is merged without updating its version in the manifest file, it was uninstallable. The dependent modules were not installed due to this issue.
it's because it's not migrated and the branch 17.0 has been created from the 16.0 one. (not from an empty branch). If you need to use this addon, you need to migrate it.
no problem, can we merge it so that this issues will vanish...
Tests and runboat are 🔴 Therefore it can't be merged.
wonderful, could you guide me on how to make it 🟢 so that everybody in the community can benefit, and I in person am learning from you 🤍
@pedrobaeza
could you guide me on how to fix this error in tests if I have to or should I add this fix to version 16.0 instead?
Downloading contextvars-2.4.tar.gz (9.6 kB) Preparing metadata (setup.py): started Preparing metadata (setup.py): finished with status 'done' Collecting fastapi>=0.110.0 (from -r test-requirements.txt (line 4)) Downloading fastapi-0.115.6-py3-none-any.whl.metadata (27 kB) Collecting graphene (from -r test-requirements.txt (line 5)) Downloading graphene-3.4.3-py2.py3-none-any.whl.metadata (6.9 kB) Collecting graphql_server (from -r test-requirements.txt (line 6)) Downloading graphql-server-3.0.0b7.tar.gz (48 kB) Preparing metadata (setup.py): started Preparing metadata (setup.py): finished with status 'done' ERROR: Could not find a version that satisfies the requirement odoo-addon-auth_jwt<17.1dev,>=17.0dev (from versions: 16.0.1.0.0.3, 16.0.1.1.0, 16.0.1.1.0.2, 16.0.1.1.0.3, 16.0.1.1.0.6, 16.0.1.1.0.7) ERROR: No matching distribution found for odoo-addon-auth_jwt<17.1dev,>=17.0dev Error: Process completed with exit code 1.
Sorry, I can't help with that, as I don't use pip deployment and don't know the internals. This repository is also not following the usual OCA workflow.
Sorry, I can't help with that, as I don't use pip deployment and don't know the internals. This repository is also not following the usual OCA workflow.
Thanks Pedro very much for your help, it's ok we can use the PR, I just wanted to make everything clean if possible.
ChatGPT have just told me that I need to update package index, which I don't know about 😅
@kobros-tech Thanks for this.
In order to get this merged:
- Please change your commit message by something like:
[MIG] fastapi_auth_jwt: Migration to 17.0 - You should reference the depending PR(s) in this one description (https://github.com/OCA/server-auth/pull/657).
- You can embed it following: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29 in order to get tests running.
@kobros-tech Moreover, before creating a migration PR, you should have checked if another does not exist.
The normal cycle requires you to review this one first: https://github.com/OCA/rest-framework/pull/452
not at all it is already there in branch 17.0 I made a fix not merge
On Tue, Dec 17, 2024, 13:35 Denis Roussel (ACSONE) @.***> wrote:
@kobros-tech https://github.com/kobros-tech Moreover, before creating a migration PR, you should have checked if another does not exist.
The normal cycle requires you to review this one first: #452 https://github.com/OCA/rest-framework/pull/452
— Reply to this email directly, view it on GitHub https://github.com/OCA/rest-framework/pull/481#issuecomment-2548096818, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWIJXBGOLBMXTVZTQPCZM2T2F745VAVCNFSM6AAAAABTXCB4QKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBYGA4TMOBRHA . You are receiving this because you were mentioned.Message ID: @.***>
not at all it is already there in branch 17.0 I made a fix not merge
The version is 16.0... because it has not been migrated, just moved to branch 17.0: that's why a migration PR/commit is needed.
@kobros-tech Indeed, as @SirAionTech said, the flow is different on this repository.
Main branches are created on preceding version main branch. So, the migration PR should contain just the migration commit (and maybe the pre-commit stuff).
@SirAionTech @rousseldenis @lmignon @pedrobaeza
Thanks all for clarification, I didn't observe that as this repository is different in workflow from others.
I can not add MIG PR, there is one already and I trust it as what I upgraded is similar to what it contains.
I encourage to merge that PR and then compare my PR to the module after merging.
Because I migrated and fixed, not just migrated.
I can provide screenshots if requested.
Thanks to the origin mig PR #452 I could add my fix, so this current PR is a combination of both migration and fix.
depending on: https://github.com/OCA/server-auth/pull/751/
@SirAionTech @rousseldenis @lmignon @pedrobaeza
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@antonyht27
shall we add my commit of this PR: e62debf53abe3b11439fd1dcf0702d6fd2deee16 or I make this PR a migration one based on yours with the same git log?
@lmignon
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.