rest-framework
rest-framework copied to clipboard
OCA
[14.0] [IMP] base_rest: support multiple types
The main goal for this PR is to add multi-type support when generating swagger docs.
At the current state, even tho cerberus validator supports multi-type validation, swagger would raise an error without giving access to the api's docs.
To do so, I've also updated Swagger UI and OpenAPI to the LTS.
Depends on #417
Hi @lmignon, some modules you are maintaining are being modified, check this out!
@renda-dev Thank you for the improment. Can you fix the tests plz?
Greetings, base_rest's test have been fixed, while fastapi's tests are still broken, even tho that module has been left untouched.
Is it possible to keep going with this PR anyway? @lmignon
It's my understanding that https://github.com/OCA/rest-framework/pull/417 is required for this PR's tests to pass, is that correct?
It's my understanding that #417 is required for this PR's tests to pass, is that correct?
Yes it is. @aleuffre
@renda-dev #417 is on its path to be merged. Once merged can you rebase your PR to make it :green_circle:
@renda-dev #417 is on its path to be merged. Once merged can you rebase your PR to make it 🟢
Done, thanks! @lmignon
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-415-by-lmignon-bump-patch, awaiting test results.
Congratulations, your PR was merged at 30cfd88816d9d18b27a7e8162082d966c75323fd. Thanks a lot for contributing to OCA. ❤️