rest-framework icon indicating copy to clipboard operation
rest-framework copied to clipboard

16.0 add fastapi auth

Open sebastienbeau opened this issue 1 year ago • 7 comments

Introduce a new authentication based on partner, you can use it instead of external auth provider like keycloak

This module is linked to fastapi (it can maybe more generic in futur version).

sebastienbeau avatar Dec 15 '23 15:12 sebastienbeau

@sebastienbeau If I'm not mistaken this work origins from https://github.com/akretion/rest-authenticable. I don't get why it has been reworked as strictly tied to fastapi. IMO beside the routers this is something that should stay in a basic module as you did before.

BTW happy new year :)

simahawk avatar Jan 05 '24 09:01 simahawk

Yes it come from here. Indeed we can split the module in two (generic, and specific to fastapi), I have hesitated As base_rest is going to died and I do not see other case of using an alternative auth, I choose to depend on fastapi to avoid to split too much the code. If we have case where the "base" code can be reuse I can resplit it.

sebastienbeau avatar Jan 08 '24 08:01 sebastienbeau

to avoid to split too much the code.

AFAIS 95% of the code would be in the standalone module, only a fraction goes into fastapi integration.

If we have case where the "base" code can be reuse I can resplit it.

IMO is better to rollback to the other approach before you start spreading it :wink:

In 4 years, when @lmignon will refactor these apis on the next api framework you'll thank yourself :stuck_out_tongue_winking_eye:

simahawk avatar Jan 15 '24 11:01 simahawk

Thanks for your feedback, we are going to re-split the module, @paradoxxxzero will work on it.

sebastienbeau avatar Feb 25 '24 09:02 sebastienbeau