rest-framework
rest-framework copied to clipboard
16.0 add fastapi auth
Introduce a new authentication based on partner, you can use it instead of external auth provider like keycloak
This module is linked to fastapi (it can maybe more generic in futur version).
@sebastienbeau If I'm not mistaken this work origins from https://github.com/akretion/rest-authenticable. I don't get why it has been reworked as strictly tied to fastapi. IMO beside the routers this is something that should stay in a basic module as you did before.
BTW happy new year :)
Yes it come from here. Indeed we can split the module in two (generic, and specific to fastapi), I have hesitated As base_rest is going to died and I do not see other case of using an alternative auth, I choose to depend on fastapi to avoid to split too much the code. If we have case where the "base" code can be reuse I can resplit it.
to avoid to split too much the code.
AFAIS 95% of the code would be in the standalone module, only a fraction goes into fastapi integration.
If we have case where the "base" code can be reuse I can resplit it.
IMO is better to rollback to the other approach before you start spreading it :wink:
In 4 years, when @lmignon will refactor these apis on the next api framework you'll thank yourself :stuck_out_tongue_winking_eye:
Thanks for your feedback, we are going to re-split the module, @paradoxxxzero will work on it.