rest-framework icon indicating copy to clipboard operation
rest-framework copied to clipboard

[16.0] Update project template

Open lmignon opened this issue 2 years ago • 9 comments

  • Uses ruff to check and format code
  • Uses pyproject.toml files in addition to the setup directory

lmignon avatar Nov 07 '23 10:11 lmignon

Hi @sbidoul, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Nov 07 '23 10:11 OCA-git-bot

/ocabot merge nobump

lmignon avatar Nov 13 '23 10:11 lmignon

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-394-by-lmignon-bump-nobump, awaiting test results.

OCA-git-bot avatar Nov 13 '23 10:11 OCA-git-bot

@lmignon The merge process could not be finalized, because command /tmp/tmpxs3yqwv4/bin/python -m build --wheel --outdir /tmp/tmp57pc8dqk --no-isolation failed with output:

Could not import runpy module
Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 14, in <module>
    import importlib.machinery # importlib first so we can test #15386 via -m
  File "/usr/lib/python3.8/importlib/__init__.py", line 57, in <module>
    import types
  File "/tmp/tmphocqur8f/graphql_base/types.py", line 4, in <module>
    import graphene
ModuleNotFoundError: No module named 'graphene'

OCA-git-bot avatar Nov 13 '23 10:11 OCA-git-bot

Weird error. I'll look into this.

sbidoul avatar Nov 13 '23 12:11 sbidoul

It's a PYTHONPATH issue creating confusion because import types unexpectedly imports types.py at the root of the graphql_base addon. I'll investigate. It might be a bug in build, not sure.

sbidoul avatar Nov 13 '23 16:11 sbidoul

Should be fixed when https://github.com/OCA/oca-github-bot/pull/270 is deployed.

sbidoul avatar Nov 14 '23 08:11 sbidoul

Should be fixed when OCA/oca-github-bot#270 is deployed.

great! Thank you.

lmignon avatar Nov 14 '23 09:11 lmignon

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Mar 17 '24 12:03 github-actions[bot]