rest-framework icon indicating copy to clipboard operation
rest-framework copied to clipboard
verified publisher icon OCA

[15.0][FIX] base_rest: `swagger_ui.js` is (sometimes) loaded first, causing crashes

Open fdegrave opened this issue 3 years ago • 2 comments

Using base_rest in Odoo 15 results sometimes in UI crashes (web client not loading) because swagger_ui.js is loaded before anything else. This is fixed by adding an explicit dependency to web.

The exact circumstances under which swagger_ui.js is loaded first is not completely clear -- usually when other modules depending on it are loaded, even when such modules don't contain JS themselves. The addition of this dependency seems to fix the issue in all cases.

fdegrave avatar Jul 28 '22 13:07 fdegrave

Hi @lmignon, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Jul 28 '22 13:07 OCA-git-bot

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Aug 02 '22 14:08 OCA-git-bot

/ocabot merge patch

etobella avatar Oct 16 '22 17:10 etobella

What a great day to merge this nice PR. Let's do it! Prepared branch 15.0-ocabot-merge-pr-272-by-etobella-bump-patch, awaiting test results.

OCA-git-bot avatar Oct 16 '22 17:10 OCA-git-bot

Congratulations, your PR was merged at 5058eda0de6ac364f638eec22a8486f9060255a5. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Oct 16 '22 17:10 OCA-git-bot