*comment_template

[risto42]

I was pleased to find the modules purchase and sales comment templates which in theory saves me the time to reimplement the preamble and tailing comments for quotations from our previous ERP system.

But I'm concerned about what seems a considerable 'omission'..

The model templates are straight forward to create for each of these models, but after instantiating the template, it appears that a direct link to the model is made from the sale or purchase instead of a copy to be locally filled in.

That is, use of the model template actually changes the model template, and behind one's back, the next user does the same... overwriting

There seems only that the 'base_comment_template' table is made, without any other comment[s] table having the actually used comments.

Is anybody using this in production that can elucidate a bit?

[pedrobaeza]

Templates are mean for that, for being static, not for copying on each quotation the content. That's not optimal for the size perspective, and also for most of the uses. If you need to change on each quotation something on the template, you can extend these modules for having a stored text.

[risto42]

OK, if I understand your reasoning, these templates should be made read-only. Rather dangerous as it stands currently.

Then, instead of [for example] installing sale_comment_template, a sale_comments module should be made to select the template with the logic indicated above, namely being modifiable in 'draft' state.

Size is not a problem at least in our use cases, having only a thousand or so comments a year to deal with in the near term. Too, compression is on the base file system for pg.

Cheers, and thanks for the prompt response.

[pedrobaeza]

If you are administrator, you can change it, but being a salesman, you are not able to change them.

[github-actions[bot]]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.