reporting-engine icon indicating copy to clipboard operation
reporting-engine copied to clipboard

[17.0][IMP]bi_sql_editor: scheduled action periodicity settings

Open GuillemCForgeFlow opened this issue 1 year ago • 4 comments

refactor Action Settings page to have all settings, renamed to Settings. Added the settings to be able to customize the periodicity of the Scheduled Action that will refresh the Materialized view.

cc @ForgeFlow

GuillemCForgeFlow avatar Jun 26 '24 07:06 GuillemCForgeFlow

Hi @legalsylvain, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Jun 26 '24 07:06 OCA-git-bot

Hi @legalsylvain, I'd like to get your input on this whenever you have some time thank you in advance 🙂

GuillemCForgeFlow avatar Jun 26 '24 07:06 GuillemCForgeFlow

Hi @GuillemCForgeFlow. Thanks for contributing. I don't get the interest of this change. (Except that all cron information are managed in the SQL view.) Could you elaborate ? Thanks !

legalsylvain avatar Jun 26 '24 08:06 legalsylvain

Hi @GuillemCForgeFlow. Thanks for contributing. I don't get the interest of this change. (Except that all cron information are managed in the SQL view.) Could you elaborate ? Thanks !

Sure, the use case for this is that the periodicity of the refresh was too low. It could be changed at Scheduled Action level, but each time the view gets recreated (because the SQL definition changes) the Scheduled Action gets back to the original parameters.

I thought it would be great to have a general settings tab, in order to fulfill this kind of information if it needs to be changed based on specific needs. We can add more settings' groups on that tab if required in the future.

What do you think?

GuillemCForgeFlow avatar Jun 26 '24 08:06 GuillemCForgeFlow

but each time the view gets recreated (because the SQL definition changes) the Scheduled Action gets back to the original parameters

You're right. That's the point. It should be changed, for exemple, disabling the cron instead of deleting it. What do you think ? It avoid to duplicate fields in both modèls.

I agree, that seems to solve the issue for both of us. I will adjust the changes then to have this in place. Thank you for the input 😄

GuillemCForgeFlow avatar Sep 02 '24 07:09 GuillemCForgeFlow

closing, I will reference the implemented solution once done 👍🏿 @legalsylvain

GuillemCForgeFlow avatar Sep 02 '24 09:09 GuillemCForgeFlow

Implemented agreed changes on https://github.com/OCA/reporting-engine/pull/928

GuillemCForgeFlow avatar Sep 02 '24 09:09 GuillemCForgeFlow