reporting-engine icon indicating copy to clipboard operation
reporting-engine copied to clipboard

[14.0][ADD] report_qweb_table_pagebreak

Open petrus-v opened this issue 2 years ago • 4 comments

Control Page Breaks in <table>s within QWeb Reports

used by:

  • https://github.com/OCA/account-invoice-reporting/pull/297
  • https://github.com/OCA/sale-reporting/pull/243

petrus-v avatar Dec 13 '23 13:12 petrus-v

Thanks for all the answers, could you please squash everything in one commit? I think that should be enough for adding a new module.

The other below comments are not blocking.

Thanks for your reviews very well cumming :)

petrus-v avatar Dec 19 '23 20:12 petrus-v

@petrus-v let me know when I can update my review:

Navigate to Reviewers in the right sidebar and click image next to the reviewer's name whose review you'd like.

(ref. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review)

Right now I'm not sure if I have to update the review because you have made a change (https://github.com/OCA/reporting-engine/compare/39a5aec24d54349ba885c12652b690ec451c4477..fea8068f9da90856ace4b52f804606a9bac66750) and rolled it back shortly after (https://github.com/OCA/reporting-engine/compare/fea8068f9da90856ace4b52f804606a9bac66750..e27f64bbeb5cca59e5cd1db005edeace5c97f793), might be a mistake due to rebasing commits.

SirAionTech avatar Dec 20 '23 08:12 SirAionTech

sorry about the mess ! yeah I've merge your suggestion to change the variable name then squash all my commit but forgot the one merged using github suggestion so I cherry-pick your suggestion and merged it as well and force push again... ! so it's ready for review :sweat_smile:

petrus-v avatar Dec 20 '23 11:12 petrus-v

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Apr 21 '24 12:04 github-actions[bot]