report-print-send
report-print-send copied to clipboard
[17.0][IMP] base_report_to_printer : add output_tray
This pull request refactors the printer tray handling in the base_report_to_printer module to support separate input and output trays, improving flexibility.
Model and Field Refactoring
- Split the generic
printing.traymodel into two distinct models:printing.tray.inputandprinting.tray.output, and updated all related fields inir.actions.report,printing.printer,printing.report.xml.action, andres.usersto use these new models for input and output trays. - Updated onchange and default behaviour methods to reset and return values for both input and output trays, ensuring correct handling when printer or tray selections change.
Printer Synchronization and Options
- Modified the printer update logic to separately synchronize input and output trays from CUPS, and added new methods for setting printer options for both tray types.
Security and Access Control
- Updated security rules to grant appropriate access to the new input and output tray models, including separate permissions for users and managers.
Tests and Backwards Compatibility
- Refactored tests to use the new input/output tray fields and models, ensuring all behaviour checks are updated and remain valid.
Miscellaneous
- Updated the module version to
17.0.1.1.2to reflect these changes.
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
Hello, here is a nice addition ready for review!
@chienandalu @pedrobaeza Maybe you would like to give a review?
These are deep changes that require migration scripts to adapt existing models and fields.
@pedrobaeza Added migration scripts.
Hi @sergio-teruel,
Just a friendly ping on this PR when you get a chance. Let me know if you have any questions or need more context!
Thanks!
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
/ocabot merge minor
What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-365-by-pedrobaeza-bump-minor, awaiting test results.
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-365-by-pedrobaeza-bump-minor.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
@pedrobaeza There is a test failure in module printer_zpl2 that I didn't see previously, is it something coming from my changes I need to fix or not related? Let me know if you are expecting something from me.
Well, I can't merge it being red, so I can't go any further.
@pedrobaeza My branch doesn't produce this error. I don't know how to resolve the issue.
It seems to be intermittent. Let's try again:
/ocabot merge minor
On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-365-by-pedrobaeza-bump-minor, awaiting test results.
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-365-by-pedrobaeza-bump-minor.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.