report-print-send icon indicating copy to clipboard operation
report-print-send copied to clipboard

Published 20 hours ago • verified publisher icon OCA

17.0 migration printer zpl2

Open MarcLSubteno opened this issue 1 year ago • 2 comments

Fix pre-commit error on #347

MarcLSubteno avatar Aug 08 '24 12:08 MarcLSubteno

@MarcLSubteno

Hello, There is an error when trying to update printers from CUPS

image

aminambk avatar Aug 21 '24 14:08 aminambk

Can you cherry pick https://github.com/OCA/report-print-send/pull/343 ?

micheledic avatar Oct 07 '24 13:10 micheledic

@micheledic Seems like your suggested PR was cherry-picked. Could you give another look and maybe approve?

gaikaz avatar Oct 30 '24 15:10 gaikaz

@OCA/reporting-engine-maintainers I hate pinging like this, but I suppose you guys are the ones to approve and merge this. Could we please get a review here? 🙏🏻

gaikaz avatar Dec 04 '24 16:12 gaikaz

Well, tests and pre-commit are failing. I will do a rebase and see if it is solved, otherwise, we will need some actions from the author.

/ocabot rebase

etobella avatar Dec 04 '24 17:12 etobella

Congratulations, PR rebased to 17.0.

OCA-git-bot avatar Dec 04 '24 17:12 OCA-git-bot

@MarcLSubteno Could you please look at the failed test and fix them?

gaikaz avatar Dec 12 '24 09:12 gaikaz

any news about to merge ?

micheledic avatar Jan 10 '25 10:01 micheledic

Removing tests shouldn't be an option @MarcLSubteno

etobella avatar Jan 10 '25 10:01 etobella