queue icon indicating copy to clipboard operation
queue copied to clipboard

[18.0][MIG] base_import_async: Migration to 18.0

Open xaviedoanhduy opened this issue 1 year ago • 1 comments

Depends on:

  • https://github.com/OCA/queue/pull/692
  • https://github.com/OCA/queue/pull/681

xaviedoanhduy avatar Oct 15 '24 09:10 xaviedoanhduy

Thank you @xaviedoanhduy, queue_job has been merged, you can remove your commit on test-requirements.txt

sebalix avatar Oct 23 '24 14:10 sebalix

Hi, thanks for the work. I've tried this addon and have a little remark: Odoo works by batches and the default batch size is 2000 lines. When importing a bigger xls file and using the "Import in the background option", by default since Odoo works by batches, one job _split_file is created for each batch. For eg for a 200.000 lines file, 10 jobs _split_file are created, and all the records are imported 10 times. Shouldn't we add an option to avoid using Odoo batches when using OCA batches?

marielejeune avatar Jan 27 '25 09:01 marielejeune

Hi @xaviedoanhduy did you have the opportunity to look at my previous comment? Thanks

marielejeune avatar Feb 18 '25 15:02 marielejeune

Hi @xaviedoanhduy did you have the opportunity to look at my previous comment? Thanks

hi @marielejeune, Thanks for bringing up the issue in here. it seems that since this commit the issue you raised has been addressed by odoo. could you take the time to check it again?

xaviedoanhduy avatar Mar 18 '25 11:03 xaviedoanhduy

Hi @xaviedoanhduy Thanks, indeed it was fixed by Odoo.

marielejeune avatar Mar 18 '25 13:03 marielejeune

/ocabot migration base_import_async /ocabot merge nobump

simahawk avatar Apr 15 '25 11:04 simahawk

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 18.0-ocabot-merge-pr-699-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot avatar Apr 15 '25 11:04 OCA-git-bot

Congratulations, your PR was merged at a8a17a0245e10a87536c9cf451ff6cb081da5f7f. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Apr 15 '25 11:04 OCA-git-bot