purchase-workflow icon indicating copy to clipboard operation
purchase-workflow copied to clipboard

[18.0] [MIG] purchase_requisition_line_description: Migration to 18.0

Open bizzappdev opened this issue 8 months ago • 3 comments

bizzappdev avatar Apr 21 '25 11:04 bizzappdev

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar May 01 '25 11:05 OCA-git-bot

There was already a migration PR here: https://github.com/OCA/purchase-workflow/pull/2301

Can you base your work on that one please? :pray:

grindtildeath avatar May 07 '25 17:05 grindtildeath

There was already a migration PR here: #2301

Can you base your work on that one please? 🙏

Yup, I agree. @bizzappdev @grindtildeath @TDu please review the https://github.com/OCA/purchase-workflow/pull/2301 Let's merge it first.

ivs-cetmix avatar May 07 '25 17:05 ivs-cetmix

@bizzappdev the #2301 has been merged, could you please rebase?

twalter-c2c avatar May 15 '25 12:05 twalter-c2c

Thank you @bizzappdev @ivs-cetmix @grindtildeath could you please take a look at whether this PR looks good to you?

twalter-c2c avatar May 15 '25 14:05 twalter-c2c

Thank you @bizzappdev @ivs-cetmix @grindtildeath could you please take a look at whether this PR looks good to you?

@twalter-c2c could you please do the functional review to ensure nothing was broken with the recent changes?

ivs-cetmix avatar May 15 '25 15:05 ivs-cetmix

Functionally looks good.

twalter-c2c avatar May 19 '25 08:05 twalter-c2c

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 18.0-ocabot-merge-pr-2653-by-ivs-cetmix-bump-nobump, awaiting test results.

OCA-git-bot avatar May 19 '25 10:05 OCA-git-bot

Congratulations, your PR was merged at 0a0cd18c514ee74e2b3382760b64e300683b8231. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar May 19 '25 10:05 OCA-git-bot