purchase-workflow icon indicating copy to clipboard operation
purchase-workflow copied to clipboard

[18.0][MIG] purchase_manual_currency: Migration to 18.0

Open AndreuOForgeFlow opened this issue 9 months ago • 1 comments

Standard Migration

Depends on: https://github.com/OCA/account-invoicing/pull/1885

@ForgeFlow

AndreuOForgeFlow avatar Mar 24 '25 13:03 AndreuOForgeFlow

@AndreuOForgeFlow In order to make testing possible, please add the dependency in the test-requirements in a separate commit, as described in https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

JordiBForgeFlow avatar May 05 '25 17:05 JordiBForgeFlow

@AndreuOForgeFlow account_manual_currency is merged. Could you update your code please?

Saran440 avatar May 23 '25 07:05 Saran440

@Saran440, done! :+1: Thanks for the reminder :)

AndreuOForgeFlow avatar May 23 '25 08:05 AndreuOForgeFlow

@AndreuOForgeFlow Functional Test. it still not work following this comment https://github.com/OCA/purchase-workflow/pull/2521#issuecomment-2696208454

Could you check please?

Saran440 avatar May 27 '25 04:05 Saran440

@AndreuOForgeFlow Functional Test. it still not work following this comment #2521 (comment)

Could you check please?

Hi @Saran440, you need to check the "Use currency purchase" option on Purchase > Configuration > Settings > Invoicing > Manual Currency Purchase - Invoice:

image

That way, the "Manual Currency" field will be checked automatically when generating the bill :+1:

AndreuOForgeFlow avatar May 27 '25 06:05 AndreuOForgeFlow

/ocabot merge nobump

HviorForgeFlow avatar Jun 04 '25 19:06 HviorForgeFlow

What a great day to merge this nice PR. Let's do it! Prepared branch 18.0-ocabot-merge-pr-2623-by-HviorForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot avatar Jun 04 '25 19:06 OCA-git-bot

It looks like something changed on 18.0 in the meantime. Let me try again (no action is required from you). Prepared branch 18.0-ocabot-merge-pr-2623-by-HviorForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot avatar Jun 04 '25 19:06 OCA-git-bot

Congratulations, your PR was merged at c7f327d5a760b64544b3dc917ab156b78c9b68a6. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jun 04 '25 19:06 OCA-git-bot