purchase-workflow icon indicating copy to clipboard operation
purchase-workflow copied to clipboard

[18.0] [MIG] purchase_triple_discount: Migration to 18.0

Open Borruso opened this issue 9 months ago • 9 comments

Issue: https://github.com/OCA/purchase-workflow/issues/2425

Borruso avatar Mar 06 '25 15:03 Borruso

/ocabot migration purchase_triple_discount

rousseldenis avatar Jun 20 '25 09:06 rousseldenis

@Borruso Could you remove test-requirements.txt commit as dependency has been merged ?

rousseldenis avatar Jun 20 '25 09:06 rousseldenis

@Borruso why did you remove default discounts on partner? https://github.com/OCA/purchase-workflow/blob/16.0/purchase_triple_discount/models/res_partner.py

odooNextev avatar Oct 06 '25 13:10 odooNextev

@Borruso can you check my PR https://github.com/Borruso/purchase-workflow/pull/1 ?

odooNextev avatar Oct 08 '25 12:10 odooNextev

@Borruso thanks 👍

odooNextev avatar Oct 10 '25 07:10 odooNextev

@Borruso thanks 👍

Issue was born because I see PR on v17

Borruso avatar Oct 10 '25 14:10 Borruso

@pedrobaeza ping

Borruso avatar Nov 06 '25 08:11 Borruso

There are requested changes. Please don't ping me if this is in hands of other.

pedrobaeza avatar Nov 06 '25 08:11 pedrobaeza

@HviorForgeFlow review

Borruso avatar Nov 06 '25 09:11 Borruso

LGTM Can be merged?

lorenzoallegrucci avatar Nov 26 '25 15:11 lorenzoallegrucci

@HviorForgeFlow is this ok, test now are all green?

patrickt-oforce avatar Nov 26 '25 15:11 patrickt-oforce

/ocabot merge nobump

HviorForgeFlow avatar Nov 26 '25 19:11 HviorForgeFlow

@HviorForgeFlow sorry can you retry merge ?

micheledic avatar Dec 01 '25 14:12 micheledic

/ocabot merge nobump

HviorForgeFlow avatar Dec 01 '25 14:12 HviorForgeFlow

What a great day to merge this nice PR. Let's do it! Prepared branch 18.0-ocabot-merge-pr-2596-by-HviorForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot avatar Dec 01 '25 14:12 OCA-git-bot

Congratulations, your PR was merged at 3945abb96296ba48d3eef4c45067a0a9472f553c. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Dec 01 '25 14:12 OCA-git-bot