[14.0][FIX] use commercial_partner_id on prepare_payment_vals method

Open njeudy opened this issue 1 year ago • 3 comments

If partner_id is used when creating payment, invoice will not detect advance payment to reconcile. so replace by commercial_partner_id.
code for invoice_paid_amount is not correct, just use amount_total and amount_residual to keep it simple !

Oct 01 '24 08:10 njeudy

@MateuGForgeFlow @HviorForgeFlow can you review it and merge ?

Oct 01 '24 09:10 njeudy

I teste it with invocie, advance and credit note and with partial payment, and now it works .. think we should update V15, V16 and V17 as well ?

Oct 01 '24 10:10 njeudy

@njeudy I'm not sure about this change because in the past as you can see here there was an issue regarding the change that you revert on da77183be96bc66a6bf1df2dcd4dcdbe937e69b4

@ygol @djtao1 can you give some feedback and review please, thanks :)

I personally never had the chance to use this module.

Oct 01 '24 13:10 HviorForgeFlow