purchase-workflow icon indicating copy to clipboard operation
purchase-workflow copied to clipboard

[16.0][IMP] purchase_requisition_tier_validation: avoid error editing alternative

Open augusto-weiss opened this issue 1 year ago • 4 comments

Before this commit:

  • Install purchase_requisition and purchase_tier_validation
  • Create a Tier Validation for purchase model
  • Create an order and an alternative
  • Request for validation for one of the purchase order
  • Try to edit (and save) the alternative order
  • You will get a ValidationError: "The operation is under validation."

After this commit:

  • You could edit the alternative (that is not under validation) without problem

augusto-weiss avatar Jan 18 '24 14:01 augusto-weiss

@leemannd @cyrilmanuel @dzungtran89 Hi everyone! Could you see the issue?

augusto-weiss avatar Jan 18 '24 16:01 augusto-weiss

Hello, ok for me for the fix. Btw I think it should be an improvement rather than a fix, because you would like to except the validation for the PO's alternatives

dzungtran89 avatar Jan 19 '24 04:01 dzungtran89

@dzungtran89 Thz!! i changed the PR name

augusto-weiss avatar Jan 29 '24 11:01 augusto-weiss

@dzungtran89 Could you approve this PR ?

augusto-weiss avatar Apr 04 '24 17:04 augusto-weiss

/ocabot merge patch

HviorForgeFlow avatar Dec 17 '24 22:12 HviorForgeFlow

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-2150-by-HviorForgeFlow-bump-patch, awaiting test results.

OCA-git-bot avatar Dec 17 '24 22:12 OCA-git-bot

It looks like something changed on 16.0 in the meantime. Let me try again (no action is required from you). Prepared branch 16.0-ocabot-merge-pr-2150-by-HviorForgeFlow-bump-patch, awaiting test results.

OCA-git-bot avatar Dec 17 '24 22:12 OCA-git-bot

Congratulations, your PR was merged at 4bfc1ee464d955fe34c48aaeb892c295a0a82f9d. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Dec 17 '24 22:12 OCA-git-bot