purchase-workflow icon indicating copy to clipboard operation
purchase-workflow copied to clipboard
verified publisher icon OCA

[16.0][MIG] purchase_request_department: migration

Open mav-adhoc opened this issue 2 years ago • 4 comments

mav-adhoc avatar Dec 06 '23 14:12 mav-adhoc

@mav-adhoc Can you please check why tests CI are failed?

AungKoKoLin1997 avatar Dec 13 '23 07:12 AungKoKoLin1997

@AungKoKoLin1997 I already fixed the tests, the problem was that this module has 'hr' as dependency and this broke the tests of purchase_request, you can check the last commit

bruno-zanotti avatar Jan 09 '24 18:01 bruno-zanotti

@AungKoKoLin1997 Can you review the PR? Thanks!

mav-adhoc avatar Apr 04 '24 12:04 mav-adhoc

@mav-adhoc I am wondering why you didn't migrate from 15.0 branch instead of 13.0. Is there any reason?

AungKoKoLin1997 avatar Apr 09 '24 02:04 AungKoKoLin1997

@AungKoKoLin1997 Sorry, my mistake. However, after checking the differences between 13.0 and 15.0 i only saw a slight difference in the purchase_request model, which of course i've included in this PR.

mav-adhoc avatar May 21 '24 17:05 mav-adhoc

Hi @AungKoKoLin1997 , could you please check this pr? thanks!

ced-adhoc avatar Jul 15 '24 16:07 ced-adhoc

@HviorForgeFlow Hello Héctor!

Can you check this pr and merge? Thank you!

jcadhoc avatar Jul 16 '24 13:07 jcadhoc

@jcadhoc @mav-adhoc commit history is broken, try to migrate from the previous major version if it is available there. thanks

HviorForgeFlow avatar Jul 17 '24 08:07 HviorForgeFlow

@HviorForgeFlow Ok! Thanks! Im going to close this PR so as we migrate this one: https://github.com/OCA/purchase-workflow/pull/2362, which is the migration from v15 to v16.

mav-adhoc avatar Jul 17 '24 20:07 mav-adhoc