[14.0][ADD] purchase_global_discount

[omar7r]

[monterl]

Hello,

Is going to be resolve not successful check to mergue to 14.0? or is it discontinue?

Salutes.

[omar7r]

Hello @monterl

This pr is waiting for approvals for merging, if you test it, and works you can do the approval. The test's fail wasn't related to this addon.

[ajaniszewska-dev]

@omar7r if it is migration - i'd expect to see past commits & module existing on older branches - probably (looking at your commits) this is a new module then?

[anmarmo1]

The module is functional but I think there's an incompatibility with the "purchase_order_general_discount" module since, when applying the global discount, the line discount doesn't apply. There are two similar modules in sales that are compatible.

I've configured the two discounts in the supplier, but in the purchase order only one of them has been applied.

I don't know if it's the expected functionality.

[anmarmo1]

@omar7r have you been able to check this?

The module is functional but I think there's an incompatibility with the "purchase_order_general_discount" module since, when applying the global discount, the line discount doesn't apply. There are two similar modules in sales that are compatible.

I've configured the two discounts in the supplier, but in the purchase order only one of them has been applied.

I don't know if it's the expected functionality.

[omar7r]

@anmarmo1 They are incompatibles, for this version and at least in the past too, in sales are incompatibles too. I have not reviewed the reason, it was not the objective of this PR, but I have encountered the problem in sales too, some time ago.

[dreispt]

/ocabot merge nobump

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-1514-by-dreispt-bump-nobump, awaiting test results.

[OCA-git-bot]

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1514-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[github-actions[bot]]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[dreispt]

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-1514-by-dreispt-bump-nobump, awaiting test results.

[github-actions[bot]]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.