OCA
[14.0][BACKPORT] project_forecast_line from 15.0 to 14.0
Removed any relation to project.project.stage, as it is not available in 14.0
Regarding project.stage, the equivalement feature on OCA is using project status. Can I suggest that you either replace odoo 15's project stage with OCA's 14.0 project status ? https://github.com/OCA/project/tree/14.0/project_status
Regarding project.stage, the equivalement feature on OCA is using project status. Can I suggest that you either replace odoo 15's project stage with OCA's 14.0 project status ? https://github.com/OCA/project/tree/14.0/project_status
I'll look into that, thanks for letting me know :+1:
Hey @ntsirintanis, thank you for your Pull Request.
It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla Here is a list of the users:
- oca-ci [email protected] (no github login found)
Appreciation of efforts, OCA CLAbot
@gurneyalex after cherry-picking https://github.com/OCA/project/pull/979 , tests started failing. More specifically, the one test that was introduced by this PR, is failing. Which is strange, because it does not fail on local. Can you please help on this?
Hey @ntsirintanis, thank you for your Pull Request.
It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla Here is a list of the users:
- @gjotten (login unknown in OCA database)
Appreciation of efforts, OCA CLAbot
It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla Here is a list of the users:
- @gjotten (login unknown in OCA database)
Oops, my bad, should be fixed soon since I sent it out just now.
@thomaspaulb @NL66278 I suspect that the reason this one test is failing, is because runboat fails as well in a specific module:
https://runboat.odoo-community.org/api/v1/builds/b2c502af6-71bb-42da-84c8-003b8937bbc7/init-log
Not really sure how to fix this. Locally though the tests are fine.
@gjotten Please go ahead and test this functionally again, if you have time
@ntsirintanis From the looks of the error message in the test run, it's a conflict between project_task_code and project_timesheet_holidays. As a first line of attack though, could you rebase your branch on the latest 14.0? You seem to be ~70 commits behind and maybe there is already something in those last commits that solved it, and we don't need to go into it. 14.0 branch itself looks green.
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ntsirintanis Could you rebase once more and we see how the tests run now
@thomaspaulb remaining problems in CI here are pre-commit as well as big failures in tests. Is this something we can bother you with?
Hm, the remaining failing test, I think, is an interaction with project_recalculate, which doesn't exist in 15.0.
I can't put my finger behind it yet, though
@thomaspaulb you feel like giving this a thumbs-up yourself as well? Or would that be a moral gray area 😄
Well I've finally managed to make the tests green, but:
- [ ] It still needs some Git love, the commit order is now all jambled. We should rebase on latest 15.0, cherry-pick in #1106 and #1145 and then our own commits to backport should come
- [ ] Of our own commits, some, but not all, should be squashed. The loop protection may have to find its way to 15.0 as well, so could be kept separate; and the test-improvement in the other module can be separate as well.
- [ ] Afterwards, it would be really nice if @gurneyalex or @yankinmax could review again as well.
@thomaspaulb I squashed something like 10 commits away, will revisit if more squashing is needed.
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
@OCA/project-service-maintainers 'no stale' should be applied here.
@ntsirintanis I believe you looked into fixing some shortcuts we made here?
@gjotten it's been a while since I pushed anything here, I'll see into making this specific none green soon. And if there are new commits for the module. It looks like that I just need to extend some tests
Hello @ntsirintanis , @gjotten ,
I added the label no stale.
I don't know much these modules. From what I understand. You still want to improve unit tests before merging?
Hello @ntsirintanis , @gjotten , I added the label
no stale.I don't know much these modules. From what I understand. You still want to improve unit tests before merging?
Thanks @leemannd . Yes. The purpose is to make this green and mergeable, ultimately. We have been using it for a while so it is quite stable.
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-975-by-leemannd-bump-nobump, awaiting test results.
@leemannd thank you very very much for merging this. Can you please reopen this one https://github.com/OCA/project/pull/976 so we can get it merged too?
Congratulations, your PR was merged at 0d0ddcc484c111772caa95e8fd260ebaab296f2a. Thanks a lot for contributing to OCA. ❤️