project icon indicating copy to clipboard operation
project copied to clipboard

[15.0] [MIG] project_category->project_type

Open Murtaza-OSI opened this issue 3 years ago • 2 comments

Ref:- project_category For Rename Module

Murtaza-OSI avatar Jul 26 '22 08:07 Murtaza-OSI

Hello, thank you for the work. Seems good unless the pre-commit.

leemannd avatar Jul 26 '22 09:07 leemannd

I thinks the Tests should be renamed as well? Not sure for the translations files. PR.

Is this module-renaming also working in case of updating a database from v14 to v15, or will there be an error that project_category is missing? I'm asking because I have similar issue here.

CRogos avatar Aug 10 '22 20:08 CRogos

@Murtaza-OSI are you still working on this topic?

CRogos avatar Sep 23 '22 08:09 CRogos

@Murtaza-OSI are you still working on this topic? IT already done

Murtaza-OSI avatar Sep 23 '22 09:09 Murtaza-OSI

Have you seen my PR https://github.com/ursais/project/pull/4 a while ago? Also the test file was not renamed?

CRogos avatar Sep 23 '22 09:09 CRogos

Have you seen my PR ursais#4 a while ago? Also the test file was not renamed?

Thank for your help. I merge your PR

Murtaza-OSI avatar Sep 23 '22 10:09 Murtaza-OSI

Can we add an empty project_category module, with this module as dependency, so that the upgrade is done correctly? Or is there any other suggestion for the transition v14->v15? I did something similia here hr_timesheet_activity_begin_end\manifest.py. Or is there any better way?

CRogos avatar Sep 23 '22 10:09 CRogos

Is this merged and brought to mainline v15 already? I'd love to see it available. Thank you so much 🙏

tobehn avatar Oct 04 '22 06:10 tobehn

Hello @gurneyalex, your comments have been attended. Could you update your review?

leemannd avatar Oct 05 '22 13:10 leemannd

Could you also have a look at this improvement for upgrade https://github.com/ursais/project/pull/5

CRogos avatar Oct 05 '22 14:10 CRogos

/ocabot merge nobump

gurneyalex avatar Oct 12 '22 14:10 gurneyalex

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 15.0-ocabot-merge-pr-950-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot avatar Oct 12 '22 14:10 OCA-git-bot

Congratulations, your PR was merged at 957f5fea5cf5a81cd3477a8e4ac85a73433f4038. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Oct 12 '22 14:10 OCA-git-bot