project icon indicating copy to clipboard operation
project copied to clipboard

[14.0][MIG] project_task_digitized_signature

Open ChristianSantamaria opened this issue 3 years ago • 6 comments

Migration to v14 Based on PR #802 and with dependencies on OCA/project-reporting/tree/14.0/project_task_report

ChristianSantamaria avatar Jul 08 '22 07:07 ChristianSantamaria

/ocabot migration project_task_digitized_signature

leemannd avatar Jul 11 '22 15:07 leemannd

Pending points/carry forward comments from v13 migration

You're right, added ROADMAP file to migration to v13 commit.

dalonsod avatar Jul 15 '22 07:07 dalonsod

@victoralmau could you review? Thanks!

dalonsod avatar Jul 18 '22 11:07 dalonsod

@victoralmau could you review? Thanks!

Sorry, I don't have time right now to review it, and I also don't know it.

victoralmau avatar Jul 21 '22 16:07 victoralmau

@bodedra @pedrobaeza could you approve it, or still are pending tasks for this PR? Thanks in advance!

dalonsod avatar Jul 29 '22 06:07 dalonsod

I let it to @bodedra, as I'm not using this module anymore.

pedrobaeza avatar Jul 29 '22 06:07 pedrobaeza

@cubells could you review? Thanks!

dalonsod avatar Nov 14 '22 17:11 dalonsod

@OCA/project-service-maintainers Would you please review it?

bodedra avatar Nov 14 '22 18:11 bodedra

I don't understand, that module is already used here:

https://github.com/solvosci/project/blob/cb113b04aa3f8da85979ac1667c8b1124ff80367/project_task_digitized_signature/report/project_task_report.xml#L3-L6

This functionality (adding signature to task report) comes from previous module versions. What dou you say, removing such functionality, that should be implemented in other module?

dalonsod avatar Nov 15 '22 15:11 dalonsod

What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-943-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot avatar Nov 15 '22 15:11 OCA-git-bot

Congratulations, your PR was merged at 16b50f427e7a3e87ad2faf5cd0e420d4d7e754fd. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Nov 15 '22 15:11 OCA-git-bot