project icon indicating copy to clipboard operation
project copied to clipboard

Published 20 hours ago • verified publisher icon OCA

[15.0][MIG] project_timeline: Migration to 15.0

Open cesar-tecnativa opened this issue 2 years ago • 7 comments

@Tecnativa TT37717

cesar-tecnativa avatar Jul 05 '22 21:07 cesar-tecnativa

/ocabot migration project_timeline

leemannd avatar Jul 06 '22 15:07 leemannd

Deppends on https://github.com/OCA/web/pull/2247

cesar-tecnativa avatar Jul 14 '22 00:07 cesar-tecnativa

Also noticed after doing some testing that timeline crashes when grouping by a many2many field (Assignees) for example, with error below.

UncaughtClientError > TypeError Uncaught Javascript Error > Cannot read properties of undefined (reading 'localeCompare') TypeError: Cannot read properties of undefined (reading 'localeCompare') at group_order (http://localhost:8069/web/assets/681-7ac6ca2/web.assets_backend.min.js:10370:21) at Array.sort () at DataSet._sort (http://localhost:8069/web_timeline/static/lib/vis-timeline/vis-timeline-graph2d.js:14783:24) at DataSet.getIds (http://localhost:8069/web_timeline/static/lib/vis-timeline/vis-timeline-graph2d.js:14642:17) at ItemSet._orderGroups (http://localhost:8069/web_timeline/static/lib/vis-timeline/vis-timeline-graph2d.js:32446:41) at ItemSet.redraw (http://localhost:8069/web_timeline/static/lib/vis-timeline/vis-timeline-graph2d.js:31842:23) at http://localhost:8069/web_timeline/static/lib/vis-timeline/vis-timeline-graph2d.js:24820:30 at Array.forEach () at Timeline._redraw (http://localhost:8069/web_timeline/static/lib/vis-timeline/vis-timeline-graph2d.js:24819:48) at Timeline._redraw (http://localhost:8069/web_timeline/static/lib/vis-timeline/vis-timeline-graph2d.js:37574:31)

chrisandrewmann avatar Jul 29 '22 07:07 chrisandrewmann

Please rebase and push for forcing the rebuild.

pedrobaeza avatar Aug 04 '22 06:08 pedrobaeza

Done @pedrobaeza

CarlosRoca13 avatar Aug 04 '22 06:08 CarlosRoca13

I'm having the same problem as stated in v14 about disappearing elements when moving them to unassigned, plus if I do double click in an item for editing it:

Peek 04-08-2022 09-43

pedrobaeza avatar Aug 04 '22 07:08 pedrobaeza

I don't have this traceback locally, seems like an issue with runboat. I tried to reset the runboat build.

jguenat avatar Aug 04 '22 08:08 jguenat

Hello @chrisandrewmann Do you also have the issues mentionned by @pedrobaeza ? On my side it works as expected.

jguenat avatar Sep 09 '22 10:09 jguenat

@jguenat I don't see them myself either, I tested on a local instance and have also deployed to my production system.

chrisandrewmann avatar Sep 09 '22 12:09 chrisandrewmann

Sorry, the concerns were already fixed:

/ocabot merge nobump

pedrobaeza avatar Sep 09 '22 15:09 pedrobaeza

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 15.0-ocabot-merge-pr-942-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot avatar Sep 09 '22 15:09 OCA-git-bot

/ocabot migration project_timeline

pedrobaeza avatar Sep 09 '22 15:09 pedrobaeza

Congratulations, your PR was merged at b3767fef09805bdc390a039956d646010b097653. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Sep 09 '22 15:09 OCA-git-bot