project icon indicating copy to clipboard operation
project copied to clipboard

[14.0][PORT] 908 from 13.0 project_timesheet_control_sale

Open bosd opened this issue 2 years ago • 3 comments

Port #908 from 13.0 to 14.0.

Added functionality to not count already invoiced timesheet lines as running timers. Fixes: https://github.com/OCA/project/issues/907

bosd avatar Apr 10 '22 18:04 bosd

/ocabot rebase

bosd avatar Apr 10 '22 19:04 bosd

Sorry @bosd you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

OCA-git-bot avatar Apr 10 '22 19:04 OCA-git-bot

@eLBati Could you review this one as well please?

bosd avatar Apr 19 '22 06:04 bosd

@bosd Code review LG! Can you rebase so runboat is rebuilt ?

AaronHForgeFlow avatar Nov 21 '22 08:11 AaronHForgeFlow

@AaronHForgeFlow Done!

bosd avatar Nov 21 '22 09:11 bosd

Code review LG!

@AaronHForgeFlow Can you leave an approving review?

bosd avatar Nov 23 '22 14:11 bosd

/ocabot migration project_timesheet_time_control_sale

leemannd avatar Nov 24 '22 08:11 leemannd

Sorry for the nitpicking. Can you include the module name in the last commit message? like

[IMP] project_timesheet_control_sale: do not count invoiced timesheet lines as running timers

AaronHForgeFlow avatar Nov 30 '22 09:11 AaronHForgeFlow

@AaronHForgeFlow Done!

bosd avatar Nov 30 '22 10:11 bosd

@bosd Thanks!

/ocabot merge nobump

AaronHForgeFlow avatar Nov 30 '22 10:11 AaronHForgeFlow

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-911-by-AaronHForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot avatar Nov 30 '22 10:11 OCA-git-bot

Congratulations, your PR was merged at 4bb9c6bdc413d51ea16aacd9c655eb7bb38f9ad0. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Nov 30 '22 10:11 OCA-git-bot