project
project copied to clipboard
OCA
[13.0] [MIG] project_task_digitized_signature
Here is TODO list for replicate same behavior in Sale Order:
- [ ] Add signature template in Task portal view
- [ ] Send "Print Task" report in a Task chatter area.
@cubells @eLBati @sysadminmatmoz @pedrobaeza I have remove dependency of web_widget_digitized_signature module. It works great. I can sign in Task and print Task report.
Now in this PR, we are facing issue with tracking message. So may we remove this tracking message feature because we remove dependency of web_widget_**** module.
Any suggestions are welcome.
The document to mimic was sales order. Is this document now posting the signature in the thread? If so, just see how it's done. If not, it's OK to remove such thing.
The document to mimic was sales order. Is this document now posting the signature in the thread? If so, just see how it's done. If not, it's OK to remove such thing.
Nope. This document doesn't post the signature in the thread. I will remove that code from test case. So this PR become green.
JFI, I haven't reviewed posting signature in the sale order.
@pedrobaeza From portal, when customer signs in SO, it posts PDF in a chatter with content "Order signed by Customer Name" plus PDF report. But no such feature in sale order form level. In SO form, just allow attached images in "Customer Signature" tab.
Here is TODO list for replicate same behavior:
- Add signature template in Task portal view
- Send "Print Task" report in a Task chatter area.
I have short deadline and will survive for now with as of now functionality. I will continue or contribute later on.
If anyone interested to take on, please feel free to do so.
Thank you @pedrobaeza for your valuable input.
OK, you can add to the ROADMAP that TODO list. Meanwhile, green Travis is required at least.
OK, you can add to the ROADMAP that TODO list. Meanwhile, green Travis is required at least.
It's :green_circle: now.
Hello @pedrobaeza this PR seems to be idle. I'm interested to make v14 migration of this addon, since I should need it in that version, not v13. Is a good approach doing, starting from this PR, the pending tasks you noticed, preserving authority, and then v14 tasks together in a v14 migration PR? Or directly make v12 to v14 migration that could be backported to v13 later, if needed? Or anything else... Thanks!
@pedrobaeza I not only migrated the module but also made it compatible with v13.0. Because there are many changes in base v13.0
@dalonsod It is best to attend a few @pedrobaeza 's comment and sign off v13.0 migration and migrate it in v14.0.
Migration proposal for v14 available in #943 . @bodedra your improvements are covered and contributors mention included
@dalonsod Wrong migration. I mentioned in https://github.com/OCA/project/pull/802#issuecomment-1176533994 that we will address @pedrobaeza 's comment and complete v13.0 migration first. And then v14.0.
If you don't want to address the above comment, then do the following away v14.0 module migration.
- Check out 14.0 branch
- cherry-pick v13.0 migration commits
- Perform 14.0 module migration
In that way, we will preserve committed history.
Hello @bodedra thanks for your comments. We simply followed original suggestion to direct migration from v12 to v14, in order to unblock this, we read your comments later, sorry.
But I'm a little bit confused, when you say "that we will address @pedrobaeza 's comment and complete v13.0 migration first", you'll saying you'll resume this? If it's right, we'll wait for it and when it's done, we'll make v14 migration.
@dalonsod No problem. I am sorry I do not have any availability to continue development work.
You can take over this PR with cherry-pick and I explain both options in above comment.
Hello @bodedra comments attended, you can check #943 v14 migration update, could you review?
- Made initial separated v13.0 pre-commit.
- Cherry-picked your v13 migration commits from here, squashed and preserved authorship. Also updated
INSTALLfile that still referredweb_widget_digitized_signature, removing it. - And at last, pre-commit and migration commits for v14.
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello @bodedra could you approve this PR and #943 ? I've made the required changes for both migrations, as suggested.
Thanks in advance!
Thank you @dalonsod for your contribution. I cannot approve my own PR. I reviewed code again and looks good.
You can review this and approve it.
This PR looks fantastic, let's merge it! Prepared branch 13.0-ocabot-merge-pr-802-by-pedrobaeza-bump-nobump, awaiting test results.
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-802-by-pedrobaeza-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-802-by-pedrobaeza-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
What a great day to merge this nice PR. Let's do it! Prepared branch 13.0-ocabot-merge-pr-802-by-pedrobaeza-bump-nobump, awaiting test results.