project icon indicating copy to clipboard operation
project copied to clipboard

[12.0][IMP] project_timesheet_time_control: Update date_time when editing date from built-in timesheet views

Open ypapouin opened this issue 4 years ago • 7 comments

When editing date from built-in timesheet views, the date_time field is not updated and it could leads to confusion.

ypapouin avatar Feb 05 '21 12:02 ypapouin

Would like to functionally test it. But there is no runboat. @ypapouin Would force pushing trigger the creation of runboat?

bosd avatar Mar 21 '22 09:03 bosd

@bosd the runboat is now up after fresh rebase.

ypapouin avatar Mar 21 '22 09:03 ypapouin

Any ideas why the date field is converted to a datetime field?? image

bosd avatar Mar 25 '22 06:03 bosd

That's necessary to have a time control. In fact the field date is not replaced, it is just hidden. The date_time field is used instead.

ypapouin avatar Mar 25 '22 10:03 ypapouin

Oops, my bad. Had uninstalled the time_control module from my system because of some issues. One project required the regular timesheets, other project using time_control. This pr propably fixes those incompatability issues. Lets merge this one and get it to v14 :)

bosd avatar Mar 25 '22 12:03 bosd

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Aug 21 '22 12:08 github-actions[bot]

Any other reviews, to get this one merged?

bosd avatar Aug 22 '22 10:08 bosd