project icon indicating copy to clipboard operation
project copied to clipboard

[18.0][ADD] project_sale_link

Open mathben opened this issue 2 months ago • 5 comments

  • copying project_purchase_link and rename purchase to sale

mathben avatar Oct 15 '25 03:10 mathben

ping @carlos-lopez-tecnativa @pedrobaeza Thanks you!

mathben avatar Dec 06 '25 03:12 mathben

Copy from where? Did the previous authors sign the OCA CLA? You should also respect the whole commit history, and rename it from the beginning with:

git filter-branch --tree-filter 'if [ -d <old_module_name> ]; then mv <old_module_name> <new_module_name>; fi' HEAD
git rebase origin/18.0

pedrobaeza avatar Dec 06 '25 09:12 pedrobaeza

Copy from where?

This repository : https://github.com/OCA/project/tree/18.0/project_purchase_link

Did the previous authors sign the OCA CLA?

I didn't check : https://github.com/OCA/project/blob/18.0/project_purchase_link/readme/CONTRIBUTORS.md

You should also respect the whole commit history, and rename it from the beginning with

The history : https://github.com/OCA/project/commits/18.0/project_purchase_link It's a little hard to copy, the history is already in this repository. I run your command to test and nothing done (except recommit all history). Thanks @pedrobaeza

mathben avatar Dec 09 '25 02:12 mathben

OK, then it's not a copy, but it's a "brother" module inspired from the other. Isn't this what sale_project do? In any case, it's OK to add it and just mention in the CREDITS.md file that this comes from project_purchase_link.

pedrobaeza avatar Dec 09 '25 07:12 pedrobaeza

Hello, we formerly already had a similar module in 13.0 -> https://github.com/OCA/project/pull/940

leemannd avatar Dec 09 '25 14:12 leemannd