project icon indicating copy to clipboard operation
project copied to clipboard

[15.0][FIX] project_timeline: Allow to install this module with project_enterprise

Open alan196 opened this issue 9 months ago • 2 comments

This PR fixes an issue added in commit https://github.com/OCA/project/commit/3689f1dfccf755c5d862c0e779ab0364215dea3a

When the module project_timeline is installed in a database with the module project_enterprise, it raises the following error:

psycopg2.errors.DuplicateColumn: column "planned_date_end" specified more than once

This is because the field planned_date_end is defined in both modules.

This PR checks if the field is already defined in the query before adding it.

Fixes https://github.com/OCA/project/issues/1433

alan196 avatar Mar 13 '25 19:03 alan196

@HugoCLU @carlos-lopez-tecnativa Could you help me to review 🙏

alan196 avatar Mar 13 '25 19:03 alan196

No, that was not what I requested. What I requested is that you make the if sentence more explicit, including quotes, comma or something, to make it match only when the exact column name is found, not in other case.

pedrobaeza avatar Mar 13 '25 19:03 pedrobaeza

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Oct 05 '25 12:10 github-actions[bot]

Superseded in https://github.com/OCA/project/pull/1564

AaronHForgeFlow avatar Oct 22 '25 15:10 AaronHForgeFlow