project icon indicating copy to clipboard operation
project copied to clipboard

[16.0][mig] project_deadline: Migration to 16.0

Open anusriNPS opened this issue 1 year ago • 4 comments

Migrating project_deadline to 16.0

Reopened PR: https://github.com/OCA/project/pull/1123

anusriNPS avatar Oct 16 '24 11:10 anusriNPS

@heliaktiv , I have reopened PR of migrating project_deadline to 16.0 and I would request you to review it

anusriNPS avatar Oct 16 '24 11:10 anusriNPS

Please squash administrative commits, as described here: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

aleuffre avatar Oct 21 '24 10:10 aleuffre

I tried to squash the commit, but it resulted in merge conflict issue related to project_hr commits, so could not do it.

When git rebase -i origin/16.0 is executed, it lists other project related repos like project_hr and showing merge conflicts related to hr project during squash

image

Is there any way to get only project_deadline related commits alone, so that it can be squashed?

anusriNPS avatar Oct 21 '24 11:10 anusriNPS

I tried to squash the commit, but it resulted in merge conflict issue related to project_hr commits, so could not do it.

When git rebase -i origin/16.0 is executed, it lists other project related repos like project_hr and showing merge conflicts related to hr project during squash

image

Is there any way to get only project_deadline related commits alone, so that it can be squashed?

I suspect your repo may be outdated. Can you try git fetch origin 16.0 and then try to rebase again?

aleuffre avatar Oct 21 '24 12:10 aleuffre

Code review: LGTM

coleste avatar Nov 21 '24 23:11 coleste

As this module is not necessary for migrating into 16.0, closing this MR

anusriNPS avatar Nov 26 '24 14:11 anusriNPS