product-variant icon indicating copy to clipboard operation
product-variant copied to clipboard

[18.0][FIX] product_attribute_value_archive: Fix issue where attribute_id may not be set

Open natuan9 opened this issue 9 months ago • 1 comments

ISSUE: In case product.attribute.value is created directly from the product form view, values parameter in create method doesn't contain attribute_id. This PR resolves this issue

image

natuan9 avatar Mar 20 '25 04:03 natuan9

Hi @mmequignon, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Mar 20 '25 04:03 OCA-git-bot

@mmequignon @rousseldenis Can you check and review the pr?

david-s73 avatar May 21 '25 10:05 david-s73

@rousseldenis I have created a new pr with the changes you have commented in this one since it does not seem that I will review the changes you indicated. https://github.com/OCA/product-variant/pull/405

david-s73 avatar May 28 '25 08:05 david-s73

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Sep 28 '25 12:09 github-actions[bot]