product-variant icon indicating copy to clipboard operation
product-variant copied to clipboard

[16.0][FIX] product_variant_configurator: change instance checking

Open Mantux11 opened this issue 10 months ago • 1 comments

Creating a new Sales Order and selecting a product in the SO line, and choosing any subscription period results in a technical error.

Checking instance (_name) should not be on a specific record, it could be done on all products. And if there is no products, getting to first record raises and Index out of range error.

This fixes Index out of range error.

Mantux11 avatar Apr 12 '24 10:04 Mantux11

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Aug 11 '24 12:08 github-actions[bot]

@carolinafernandez-tecnativa Mind having a look since you migrated this to 16.0 and all.

Du-ma avatar Sep 05 '24 11:09 Du-ma

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-346-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot avatar Sep 05 '24 13:09 OCA-git-bot

Congratulations, your PR was merged at 1f598ec7f683a4bb0e69cb199e733c469df0093c. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Sep 05 '24 13:09 OCA-git-bot