OCA
[18.0] [MIG] product_configurator: Migration to 18.0
@ivantodorovich Thank you so much for your review and for pointing out the missing points and improvements. We have made the necessary changes.
The sales part is still missing
@yterrettaz For the sales part, you are most welcome to test and provide your feedback at https://github.com/OCA/product-configurator/pull/151
The sales part is still missing
@yterrettaz For the sales part, you are most welcome to test and provide your feedback at #151
Yes, with pleasure, but I don't have a runbot for that yet.
Hello, I would like to suggest a commit.
The changes concern an optimization that avoid the recompute of the attribute's conditions for every view generation. These are now computed and stored on the product.template.attribute.line. The difference is notable mainly for complexe configuration and for the portal part.
Secondly, the changes split the compute of the conditions into three distinct methods, it should be easier to inherit them to have more complexe attribute's conditions.
https://github.com/Killance/product-configurator/commit/0f7850f324c072f2c843d6453051e6a7f74e9b17
Hello, I would like to suggest a commit.
The changes concern an optimization that avoid the recompute of the attribute's conditions for every view generation. These are now computed and stored on the product.template.attribute.line. The difference is notable mainly for complexe configuration and for the portal part.
Secondly, the changes split the compute of the conditions into three distinct methods, it should be easier to inherit them to have more complexe attribute's conditions.
This change make the required, readonly and invisible conditions easier to understand. It would be appreciate to have it in the product_configurator module. @bizzappdev , what do you think about it ? Could you cherry-pick this commit in your branche ?
@BenjaHe We will check and test for functionality and performance. also might be for future compatibility for website module.
I just opened an issue for version 18 -> https://github.com/OCA/product-configurator/issues/161
@bizzappdev Any news on the handling of the proposed patch?
@gurneyalex We have scheduled this for this week's sprint. Most probably it will be ready by next Monday
@BenjaHe The cherry picking and testing of the entire functionality is done. Thank you for the contribution. cc @gurneyalex .
@yterrettaz With cherry pick the issue #161 is also fixed.
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
This PR looks fantastic, let's merge it! Prepared branch 18.0-ocabot-merge-pr-150-by-gurneyalex-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 87e851e515727494a5f9a0733863c248d1a5fe23. Thanks a lot for contributing to OCA. ❤️