[18.0][REF] product_pricelist_direct_print_xlsx
Code refactoring made with purpose of making the module easier to extend. Since xlsxwriter is "write only" library, there was no way to easily change the properties of printed table. The changes are focused on separating preparation of data / labels / formats.
That way any extension module can change the order of the columns, data formats or add new columns anywhere in the table. For example, prior to this change, to add a new column before the "Description" column, only way was to override _create_product_pricelist_sheet and _fill_data methods or rewrite whole workbook from scratch after the original methods are done.
ping @CarlosRoca13 @pedrobaeza @carlosdauden @eduezerouali-tecnativa I'm not sure who is the maintainer of the module, so I'm pinging last contributors / reviewers.
OK about the initial purpose. Please check CI.
@pedrobaeza CI is failing, but it's not related to current changes.
@pedrobaeza rebased, tests passing.
/ocabot merge patch
What a great day to merge this nice PR. Let's do it! Prepared branch 18.0-ocabot-merge-pr-2108-by-pedrobaeza-bump-patch, awaiting test results.
Congratulations, your PR was merged at 481a98a77c64634dd042638ba3194d3854e9b92a. Thanks a lot for contributing to OCA. ❤️